From 208f6134a69c243e050904a6692c9341c6fab8b5 Mon Sep 17 00:00:00 2001 From: qsm-odoo Date: Wed, 12 May 2021 10:22:32 +0000 Subject: [PATCH] [FIX] test_themes: add a test which goes over all theme tours This is a backport of [1] which at the same time finally enables the test to be able to test all theme tours. Notice that the tours should be improved so that each step properly checks that the previous step actually had an effect (as those tours are normally made to display to the user and were not designed for testing). However, this is already really useful as only checking if *entering* edit mode in each theme does not crash is already covering most issues that can be created when designing a theme at the moment. [1]: https://github.com/odoo/design-themes/commit/52fef46388ec880af78c5a5f3e6152c4510548f4 closes odoo/design-themes#533 X-original-commit: 0ed42f903c5ea10e64241ce4b85e6ddeb06d57c6 Signed-off-by: Romain Derie (rde) Signed-off-by: Quentin Smetz (qsm) --- test_themes/tests/test_crawl.py | 13 +++++++++---- 1 file changed, 9 insertions(+), 4 deletions(-) diff --git a/test_themes/tests/test_crawl.py b/test_themes/tests/test_crawl.py index 397f9850e..846e1a7dd 100644 --- a/test_themes/tests/test_crawl.py +++ b/test_themes/tests/test_crawl.py @@ -1,8 +1,6 @@ # -*- coding: utf-8 -*- # Part of Odoo. See LICENSE file for full copyright and licensing details. -import unittest - from odoo.tests import HttpCase, tagged @@ -40,9 +38,16 @@ class Crawler(HttpCase): self.authenticate('admin', 'admin') test_crawling() - # Does not work without editor fix but really useful to build the pages automatically with cr.commit() - @unittest.skip + # Note: this test is also really useful to build the default pages + # automatically by adding cr.commit() at the end of the tour def test_02_homepage_tour_every_theme(self): + # TODO All the theme tours that are runned during this test should be + # improved so that each step properly checks that the previous step + # actually had an effect (as those tours are normally made to display to + # the user and were not designed for testing). However, this is already + # really useful as only checking if *entering* edit mode in each theme + # does not crash is already covering most issues that can be created + # when designing a theme at the moment. Website = self.env['website'] websites_themes = Website.get_test_themes_websites() for website in websites_themes: