From 76e9cbcdb672f54f8fef24af2ee3d96cb2955bf5 Mon Sep 17 00:00:00 2001 From: Benoit Socias Date: Mon, 23 Oct 2023 14:43:38 +0200 Subject: [PATCH] [FIX] theme_*: remove duplicate and conflicting classes When default snippets have been updated to rely on color presets ([1]), some themes were not adapted accordingly. This also happened whenever paddings of base blocks were modified. Because of this there are elements in themes for which some classes are applied several times, and some where classes are not removed before adding a contradicting one. This commit adjusts the classes so that themes neither: - produce snippets with duplicated classes - produce snippets with contradicting classes (e.g. two different bottom paddings on the same element) This commit also fixes a typo from [2] which was the source of duplicate classes. [1]: https://github.com/odoo/odoo/commit/5953c4df6b9c08519f64a65c1cf5d5558d59f7d4 [2]: https://github.com/odoo/design-themes/commit/299d504df31bf179775eec1d37e71605c3637460#diff-86c142838104de06e89f629c51cf791464538dc8899e6a3f00c24f69638db409R34 task-3562147 X-original-commit: f3da06dc68b23816a4a884f39d0198727771cc5b Part-of: odoo/design-themes#744 --- theme_anelusia/views/snippets/s_call_to_action.xml | 3 --- theme_anelusia/views/snippets/s_company_team.xml | 2 +- theme_artists/views/snippets/s_carousel.xml | 2 +- theme_artists/views/snippets/s_comparisons.xml | 2 +- theme_artists/views/snippets/s_features.xml | 4 ++-- theme_artists/views/snippets/s_features_grid.xml | 6 +++--- theme_artists/views/snippets/s_process_steps.xml | 4 ++-- theme_artists/views/snippets/s_three_columns.xml | 2 +- theme_avantgarde/views/customizations.xml | 5 +---- theme_beauty/views/snippets/s_company_team.xml | 2 +- theme_bewise/views/customizations.xml | 14 +++++--------- theme_bistro/views/snippets/s_numbers.xml | 2 +- theme_bistro/views/snippets/s_product_catalog.xml | 2 +- theme_bistro/views/snippets/s_quotes_carousel.xml | 3 --- theme_bookstore/views/snippets/s_masonry_block.xml | 3 +-- theme_buzzy/views/snippets/s_comparisons.xml | 2 +- theme_buzzy/views/snippets/s_features.xml | 2 +- theme_buzzy/views/snippets/s_media_list.xml | 4 ---- theme_buzzy/views/snippets/s_process_steps.xml | 2 +- theme_buzzy/views/snippets/s_three_columns.xml | 5 ----- theme_buzzy/views/snippets/s_timeline.xml | 8 ++++---- theme_clean/views/snippets/s_features.xml | 4 ++-- theme_clean/views/snippets/s_quotes_carousel.xml | 1 - theme_graphene/views/customizations.xml | 4 ++-- theme_kea/views/snippets/s_features.xml | 6 +++--- theme_kea/views/snippets/s_media_list.xml | 2 +- theme_kea/views/snippets/s_numbers.xml | 2 +- theme_loftspace/views/snippets/s_comparisons.xml | 2 +- theme_loftspace/views/snippets/s_features.xml | 4 ++-- theme_loftspace/views/snippets/s_features_grid.xml | 4 ++-- theme_loftspace/views/snippets/s_media_list.xml | 4 ---- theme_loftspace/views/snippets/s_three_columns.xml | 2 +- theme_monglia/views/customizations.xml | 4 ++-- .../views/snippets/s_comparisons.xml | 4 ++-- theme_odoo_experts/views/snippets/s_media_list.xml | 2 +- .../views/snippets/s_three_columns.xml | 2 +- theme_paptic/views/customizations.xml | 10 +++++----- theme_real_estate/views/snippets/s_image_text.xml | 2 +- theme_real_estate/views/snippets/s_text_block.xml | 2 +- theme_vehicle/views/customizations.xml | 12 ++++++------ theme_yes/views/snippets/s_carousel.xml | 2 +- theme_yes/views/snippets/s_quotes_carousel.xml | 1 - theme_zap/views/snippets/s_numbers.xml | 2 +- theme_zap/views/snippets/s_references.xml | 12 ++++++------ 44 files changed, 70 insertions(+), 99 deletions(-) diff --git a/theme_anelusia/views/snippets/s_call_to_action.xml b/theme_anelusia/views/snippets/s_call_to_action.xml index 7bccfd974..216c0cd21 100644 --- a/theme_anelusia/views/snippets/s_call_to_action.xml +++ b/theme_anelusia/views/snippets/s_call_to_action.xml @@ -34,9 +34,6 @@ text-align: center; - - - Discover it diff --git a/theme_anelusia/views/snippets/s_company_team.xml b/theme_anelusia/views/snippets/s_company_team.xml index 6a457b4f9..a28f4af55 100644 --- a/theme_anelusia/views/snippets/s_company_team.xml +++ b/theme_anelusia/views/snippets/s_company_team.xml @@ -4,7 +4,7 @@ diff --git a/theme_artists/views/snippets/s_features_grid.xml b/theme_artists/views/snippets/s_features_grid.xml index f0b35893e..2f51ee09f 100644 --- a/theme_artists/views/snippets/s_features_grid.xml +++ b/theme_artists/views/snippets/s_features_grid.xml @@ -17,13 +17,13 @@ - + - + - + diff --git a/theme_artists/views/snippets/s_process_steps.xml b/theme_artists/views/snippets/s_process_steps.xml index 2c421c581..7baca6f51 100644 --- a/theme_artists/views/snippets/s_process_steps.xml +++ b/theme_artists/views/snippets/s_process_steps.xml @@ -8,10 +8,10 @@ - + - + diff --git a/theme_artists/views/snippets/s_three_columns.xml b/theme_artists/views/snippets/s_three_columns.xml index 18e3b54cb..5bc8bf24b 100644 --- a/theme_artists/views/snippets/s_three_columns.xml +++ b/theme_artists/views/snippets/s_three_columns.xml @@ -4,7 +4,7 @@ diff --git a/theme_kea/views/snippets/s_features.xml b/theme_kea/views/snippets/s_features.xml index 604a5794f..8432edfdb 100644 --- a/theme_kea/views/snippets/s_features.xml +++ b/theme_kea/views/snippets/s_features.xml @@ -8,7 +8,7 @@ - + @@ -21,7 +21,7 @@ - + @@ -34,7 +34,7 @@ - + diff --git a/theme_kea/views/snippets/s_media_list.xml b/theme_kea/views/snippets/s_media_list.xml index 439a2544b..d4e6c607f 100644 --- a/theme_kea/views/snippets/s_media_list.xml +++ b/theme_kea/views/snippets/s_media_list.xml @@ -4,7 +4,7 @@