From a945545ba8d1ed3d7df62e0efecd172e580e8e35 Mon Sep 17 00:00:00 2001
From: "Chrysanthe (chgo)" <chgo@odoo.com>
Date: Tue, 23 Jul 2024 13:30:43 +0200
Subject: [PATCH] [IMP] theme_*: review s_banner templates

This commit aims to review all the occurrences of the `s_banner`
snippet across the themes in order to fix broken selectors, the `s_hr` in
our case, as it does not exist anymore in the snippet.

task-3665300

closes odoo/design-themes#827

Related: odoo/odoo#172725
Signed-off-by: Benoit Socias (bso) <bso@odoo.com>
---
 theme_buzzy/views/snippets/s_banner.xml       | 2 --
 theme_cobalt/views/customizations.xml         | 2 --
 theme_enark/views/snippets/s_banner.xml       | 2 --
 theme_kiddo/views/snippets/s_banner.xml       | 3 ---
 theme_real_estate/views/snippets/s_banner.xml | 3 ---
 theme_zap/views/snippets/s_banner.xml         | 2 --
 6 files changed, 14 deletions(-)

diff --git a/theme_buzzy/views/snippets/s_banner.xml b/theme_buzzy/views/snippets/s_banner.xml
index 8559584e2..184cddc85 100644
--- a/theme_buzzy/views/snippets/s_banner.xml
+++ b/theme_buzzy/views/snippets/s_banner.xml
@@ -12,8 +12,6 @@
    <xpath expr="//div[hasclass('o_grid_item_image')]" position="replace"/>
    <xpath expr="//div[hasclass('o_grid_item_image')]" position="replace"/>
    <xpath expr="//div[hasclass('o_grid_item_image')]" position="replace"/>
-   <!-- Remove hr -->
-   <xpath expr="//div[hasclass('s_hr')]" position="replace"/>
    <!-- Row - remove grid mode -->
    <xpath expr="//div[hasclass('row')]" position="attributes">
       <attribute name="class" remove="o_grid_mode" separator=" "/>
diff --git a/theme_cobalt/views/customizations.xml b/theme_cobalt/views/customizations.xml
index 89989db0c..185a3e4fc 100644
--- a/theme_cobalt/views/customizations.xml
+++ b/theme_cobalt/views/customizations.xml
@@ -20,8 +20,6 @@
     <xpath expr="//div[hasclass('o_grid_item_image')]" position="replace"/>
     <xpath expr="//div[hasclass('o_grid_item_image')]" position="replace"/>
     <xpath expr="//div[hasclass('o_grid_item_image')]" position="replace"/>
-    <!-- Remove hr -->
-    <xpath expr="//div[hasclass('s_hr')]" position="replace"/>
     <!-- Image -->
     <xpath expr="//div[hasclass('col-lg-6')]" position="after">
         <div class="pt16 pb16 o_colored_level col-lg-5 offset-lg-1">
diff --git a/theme_enark/views/snippets/s_banner.xml b/theme_enark/views/snippets/s_banner.xml
index 584befaf6..ad0106c88 100644
--- a/theme_enark/views/snippets/s_banner.xml
+++ b/theme_enark/views/snippets/s_banner.xml
@@ -14,8 +14,6 @@
     <xpath expr="//div[hasclass('o_grid_item_image')]" position="replace"/>
     <xpath expr="//div[hasclass('o_grid_item_image')]" position="replace"/>
     <xpath expr="//div[hasclass('o_grid_item_image')]" position="replace"/>
-    <!-- Remove hr -->
-    <xpath expr="//div[hasclass('s_hr')]" position="replace"/>
     <!-- Row - remove grid mode -->
     <xpath expr="//div[hasclass('row')]" position="attributes">
         <attribute name="class" remove="o_grid_mode" separator=" "/>
diff --git a/theme_kiddo/views/snippets/s_banner.xml b/theme_kiddo/views/snippets/s_banner.xml
index 5735aa430..eee8e7269 100644
--- a/theme_kiddo/views/snippets/s_banner.xml
+++ b/theme_kiddo/views/snippets/s_banner.xml
@@ -18,9 +18,6 @@
     <xpath expr="//div[hasclass('o_grid_item_image')]" position="replace"/>
     <xpath expr="//div[hasclass('o_grid_item_image')]" position="replace"/>
     <xpath expr="//div[hasclass('o_grid_item_image')]" position="replace"/>
-    
-    <!-- Remove hr -->
-    <xpath expr="//div[hasclass('s_hr')]" position="replace"/>
 
     <!-- Filter -->
     <xpath expr="//div[hasclass('container')]" position="before">
diff --git a/theme_real_estate/views/snippets/s_banner.xml b/theme_real_estate/views/snippets/s_banner.xml
index ce81841c5..0a3003aa9 100644
--- a/theme_real_estate/views/snippets/s_banner.xml
+++ b/theme_real_estate/views/snippets/s_banner.xml
@@ -24,9 +24,6 @@
     <xpath expr="//div[hasclass('o_grid_item_image')]" position="replace"/>
     <xpath expr="//div[hasclass('o_grid_item_image')]" position="replace"/>
 
-    <!-- Remove hr -->
-    <xpath expr="//div[hasclass('s_hr')]" position="replace"/>
-
     <!-- Jumbotron -->
     <xpath expr="//div[hasclass('col-lg-5')]" position="attributes">
         <attribute name="class" add="col-lg-7 h-100 pt160 pb160" remove="o_grid_item g-height-4 g-col-lg-5 col-lg-5" separator=" "/>
diff --git a/theme_zap/views/snippets/s_banner.xml b/theme_zap/views/snippets/s_banner.xml
index c8b647576..bb055f5c5 100644
--- a/theme_zap/views/snippets/s_banner.xml
+++ b/theme_zap/views/snippets/s_banner.xml
@@ -18,8 +18,6 @@
     <xpath expr="//div[hasclass('o_grid_item_image')]" position="replace"/>
     <xpath expr="//div[hasclass('o_grid_item_image')]" position="replace"/>
     <xpath expr="//div[hasclass('o_grid_item_image')]" position="replace"/>
-    <!-- Remove hr -->
-    <xpath expr="//div[hasclass('s_hr')]" position="replace"/>
     <!-- Column -->
     <xpath expr="//*[hasclass('col-lg-5')]" position="attributes">
         <attribute name="class" add="col-lg-8 pt48 pb32 px-5 o_cc o_cc1 rounded" remove="o_grid_item g-height-4 g-col-lg-5 col-lg-5" separator=" "/>