From e05e835b2820b6ea88eec70f8435f2106a940841 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?S=C3=A9bastien=20Mottet=20=28oms=29?= <oms@odoo.com>
Date: Wed, 7 Jul 2021 08:52:07 +0000
Subject: [PATCH] [FIX] theme_*: check cta_btn_text is not False before
 applying upper
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

The themes cobalt, paptic and vehicle apply upper on cta_btn_text for some
snippets. In some case cta_btn_text is a boolean (False) and not a string.
We must check cta_btn_text is not False before calling upper on it.

task-2518565

closes odoo/design-themes#33

Signed-off-by: Jérémy Kersten (jke) <jke@openerp.com>
---
 theme_cobalt/views/customizations.xml  | 2 +-
 theme_paptic/views/customizations.xml  | 2 +-
 theme_vehicle/views/customizations.xml | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/theme_cobalt/views/customizations.xml b/theme_cobalt/views/customizations.xml
index 1928949f9..c339f7ed1 100644
--- a/theme_cobalt/views/customizations.xml
+++ b/theme_cobalt/views/customizations.xml
@@ -169,7 +169,7 @@
 <!-- ==== Call To Action ===== -->
 <template id="s_call_to_action" inherit_id="website.s_call_to_action" name="Cobalt s_call_to_action">
     <xpath expr="//t[@t-esc='cta_btn_text']" position="replace">
-        <t t-esc="cta_btn_text.upper()">START NOW</t>
+        <t t-esc="cta_btn_text and cta_btn_text.upper()">START NOW</t>
     </xpath>
 </template>
 
diff --git a/theme_paptic/views/customizations.xml b/theme_paptic/views/customizations.xml
index 9d0143f12..918fa33e0 100644
--- a/theme_paptic/views/customizations.xml
+++ b/theme_paptic/views/customizations.xml
@@ -52,7 +52,7 @@
     <xpath expr="//p[2]" position="replace">
         <p class="text-o-color-3">
             <a href="#" class="btn btn-lg btn-primary mb-2">START NOW</a>&#160;&#160;&#160;&#160;
-            <a t-att-href="cta_btn_href" class="btn btn-lg btn-secondary mb-2"><t t-esc="cta_btn_text.upper()">SCHEDULE A DEMO</t></a>
+            <a t-att-href="cta_btn_href" class="btn btn-lg btn-secondary mb-2"><t t-esc="cta_btn_text and cta_btn_text.upper()">SCHEDULE A DEMO</t></a>
         </p>
     </xpath>
 
diff --git a/theme_vehicle/views/customizations.xml b/theme_vehicle/views/customizations.xml
index 18a846e0e..a8401fb31 100644
--- a/theme_vehicle/views/customizations.xml
+++ b/theme_vehicle/views/customizations.xml
@@ -10,7 +10,7 @@
         <font style="font-size: 62px;font-weight: bold;">Start the Engine</font>
     </xpath>
     <xpath expr="//a[hasclass('btn')]" position="replace">
-        <a t-att-href="cta_btn_href" class="btn btn-primary btn-lg mb-2"><t t-esc="cta_btn_text.upper()">START THE ENGINE</t></a>
+        <a t-att-href="cta_btn_href" class="btn btn-primary btn-lg mb-2"><t t-esc="cta_btn_text and cta_btn_text.upper()">START THE ENGINE</t></a>
     </xpath>
 </template>