[IMP] theme_*: explode masonry snippet

See community commit for details

Note: this also fixes avantgarde svg/screenshot at the same time: we
remove the s_masonry_block but add the missing carousel.

(image contribution by MANO)

closes odoo/design-themes#1020

Related: odoo/odoo#183755
Related: odoo/upgrade#6642
Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>
Co-authored-by: mano-odoo <mano@odoo.com>

theme_beauty/__manifest__.py

@@ -76,7 +76,7 @@
         'website.s_carousel_default_image_2': '/theme_beauty/static/src/img/snippets/s_carousel_2.jpg',
     },
     'configurator_snippets': {
-        'homepage': ['s_intro_pill', 's_masonry_block', 's_pricelist_boxed', 's_features_wall', 's_image_frame', 's_call_to_action'],
+        'homepage': ['s_intro_pill', 's_masonry_block_mosaic_template', 's_pricelist_boxed', 's_features_wall', 's_image_frame', 's_call_to_action'],
     },
     'license': 'LGPL-3',
     'live_test_url': 'https://theme-beauty.odoo.com',

theme_beauty/static/src/js/tour.js

@@ -9,7 +9,7 @@ const snippets = [
         groupName: "Intro",
     },
     {
-        id: 's_masonry_block',
+        id: 's_masonry_block_mosaic_template',
         name: 'Masonry',
         groupName: "Images",
     },

theme_beauty/views/snippets/s_masonry_block.xml

@@ -1,15 +1,6 @@
 <?xml version="1.0" encoding="utf-8"?>
 <odoo>
 
-<template id="s_masonry_block" inherit_id="website.s_masonry_block">
-    <xpath expr="//t[@t-call='website.s_masonry_block_default_template']" position="replace">
-        <t t-call="website.s_masonry_block_mosaic_template"/>
-    </xpath>
-    <xpath expr="//section" position="attributes">
-        <attribute name="data-masonry-template">mosaic</attribute>
-    </xpath>
-</template>
-
 <template id="s_masonry_block_mosaic_template" inherit_id="website.s_masonry_block_mosaic_template">
     <xpath expr="//img" position="attributes">
         <attribute name="class" add="rounded" separator=" "/>