[IMP] theme_*: explode masonry snippet

See community commit for details

Note: this also fixes avantgarde svg/screenshot at the same time: we
remove the s_masonry_block but add the missing carousel.

(image contribution by MANO)

closes odoo/design-themes#1020

Related: odoo/odoo#183755
Related: odoo/upgrade#6642
Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>
Co-authored-by: mano-odoo <mano@odoo.com>

theme_paptic/__manifest__.py

@@ -18,7 +18,7 @@
         'static/description/paptic_screenshot.jpg',
     ],
     'configurator_snippets': {
-        'homepage': ['s_cover', 's_references', 's_image_text', 's_text_image', 's_masonry_block', 's_faq_list', 's_cta_box'],
+        'homepage': ['s_cover', 's_references', 's_image_text', 's_text_image', 's_masonry_block_images_template', 's_faq_list', 's_cta_box'],
     },
     'new_page_templates': {
         'about': {

theme_paptic/static/src/js/tour.js

@@ -24,7 +24,7 @@ const snippets = [
         groupName: "Content",
     },
     {
-        id: 's_masonry_block',
+        id: 's_masonry_block_images_template',
         name: 'Masonry',
         groupName: "Images",
     },

theme_paptic/views/customizations.xml

@@ -745,15 +745,6 @@
 </template>
 
 <!-- ==== Masonry Block ===== -->
-<template id="s_masonry_block" inherit_id="website.s_masonry_block">
-    <xpath expr="//t[@t-call='website.s_masonry_block_default_template']" position="replace">
-        <t t-call="website.s_masonry_block_images_template"/>
-    </xpath>
-    <xpath expr="//section" position="attributes">
-        <attribute name="data-masonry-template">images</attribute>
-    </xpath>
-</template>
-
 <template id="s_masonry_block_images_template" inherit_id="website.s_masonry_block_images_template">
     <xpath expr="//div[hasclass('row')]" position="attributes">
         <attribute name="data-row-count">11</attribute>