NextERP/design-themes
2
0
Fork 0
mirror of https://github.com/odoo/design-themes.git synced 2025-10-07 01:18:52 +07:00
Code Issues Packages Projects Releases Wiki Activity

[FIX] theme_*: remove duplicate and conflicting classes

Browse Source 
When default snippets have been updated to rely on color presets ([1]),
some themes were not adapted accordingly.
This also happened whenever paddings of base blocks were modified.
Because of this there are elements in themes for which some classes are
applied several times, and some where classes are not removed before
adding a contradicting one.

This commit adjusts the classes so that themes neither:
- produce snippets with duplicated classes
- produce snippets with contradicting classes (e.g. two different
bottom paddings on the same element)

This commit also fixes a typo from [2] which was the source of
duplicate classes.

[1]: https://github.com/odoo/odoo/commit/5953c4df6b9c08519f64a65c1cf5d5558d59f7d4
[2]: https://github.com/odoo/design-themes/commit/299d504df31bf179775eec1d37e71605c3637460#diff-86c142838104de06e89f629c51cf791464538dc8899e6a3f00c24f69638db409R34

task-3562147

Part-of: odoo/design-themes#731
This commit is contained in:
Benoit Socias
2023-10-23 14:43:38 +02:00
parent cd421c73ce
commit f3da06dc68
44 changed files with 70 additions and 99 deletions
Download Patch File Download Diff File Expand all files Collapse all files
theme_real_estate/views/snippets/s_image_text.xml
+1 -1
View File
@@ -4,7 +4,7 @@
<template id="s_image_text" inherit_id="website.s_image_text">
<!-- Section -->
<xpath expr="//section" position="attributes">
<attribute name="class" add="o_cc o_cc1 pb48 pt48" remove="pb32 pb32" separator=" "/>
<attribute name="class" add="o_cc o_cc1 pb48 pt48" remove="pb32 pt32" separator=" "/>
</xpath>
<!-- Title -->
theme_real_estate/views/snippets/s_text_block.xml
+1 -1
View File
@@ -4,7 +4,7 @@
<template id="s_text_block" inherit_id="website.s_text_block">
<!-- Section/span -->
<xpath expr="//section" position="attributes">
<attribute name="class" add="o_cc o_cc4 pb56 pt56" remove="pt96 pb96" separator=" "/>
<attribute name="class" add="o_cc o_cc4 pb56 pt56" remove="pt40 pb40" separator=" "/>
</xpath>
<xpath expr="//p" position="replace" mode="inner">
We are <b>Odoo Travel Agency</b>, dedicated to making your vacation dreams come true! Overwhelmed with too many choices on the internet? We offer you answers, support, advice, and itineraries that will amaze you with their <b>thoroughness and thoughtfulness</b>.