This commit adapts the themes to the new Parallax effect structure.
We now wrap the parallax element in another element with
"overflow: hidden" to avoid setting "overflow: hidden" on sections.
That was causing elements like the dropdown of the search bar to be cut
off and not fully visible.
task-4926420
closesodoo/design-themes#1114
Related: odoo/odoo#218296
Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>
ormcache invalidation in test_02_homepage_tour_every_theme test.
The configurator_apply method and various methods used for theme added
on `ir.module.module` from website write directely on `ir.model.data`
and update attachments, views, xmlids. They are missing invalidations
of template ormcache and others.
Adding a high-level cache revealed the problem, but this issue
already exists, it impacts all template caches such as `website.page`
and `ir.qweb`.
see odoo/odoo#224487
see odoo/odoo#88276closesodoo/design-themes#1164
X-original-commit: c0d05fff10
Related: odoo/odoo#229552
Related: odoo/enterprise#96044
Signed-off-by: Christophe Matthieu (chm) <chm@odoo.com>
Commit [1] copies configurator pages during the flow. When the
standalone test leaves website_id in the context, that copy now tries
to create generic views with a website-scoped environment and hits the
ir.ui.view guard. Running the configurator inside MockRequest mimics the
real HTTP context (request-driven website, no forced id on the ORM), so
the copy succeeds and the test passes again.
[1]: https://github.com/odoo/odoo/commit/4231c9e545fdebdad034a4418f2a11e6691bac61
runbot-232963
closesodoo/design-themes#1160
X-original-commit: 501f57e840
Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>
The standalone theme configurator test
(test_02_theme_default_generate_primary_templates) failed locally
because `configurator_apply()` attempts to perform real HTTP requests
through `_website_api_rpc()` and `_OLG_api_rpc()`.
Standalone tests run without network access by design, so these calls
must be mocked to ensure deterministic behavior.
This commit patches both RPC methods during the test execution to return
minimal, valid fake payloads.
IAP itself does not need to be tested here: its behavior and endpoints
are already covered indirectly by the configurator_flow web tour test in
test_website_modules, which exercises the full configurator flow
end-to-end with real network access.
runbot-231270
closesodoo/design-themes#1157
X-original-commit: 42b78a247d
Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>
The testing suite tests, among other things, that a s_xxx_yyy class can
only be used on a sub-element (or the same element) of a s_xxx one (or
being on the root element, as being the name of the snippet).
This commit now also allows s_something_xxx (so prefixing instead of
suffixing) when on the same element. E.g. "s_newsletter_benefits_popup"
alongside the "s_popup" class for the new "s_newsletter_benefits_popup"
snippet.
Related to task-4306887
Part of task-4077427
closesodoo/design-themes#1130
Related: odoo/odoo#186820
Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>
This commit whitelists dynamic snippet layout classes in the themes test
for blog posts and events. These layouts are now individually accessible
via the snippet selection dialog, with a separate snippet available for
each layout.
This commit also updates conflicting padding class rules to allow
combinations like `p-size(i) p[s|e|t|...]-size(j)` in snippets, while
still preventing invalid combinations such as `p-size(i) p-size(j)`.
task-4280375
closesodoo/design-themes#1127
Related: odoo/odoo#190514
Related: odoo/enterprise#75556
Signed-off-by: Serge Bayet (seba) <seba@odoo.com>
The test was incorrectly flagging inner classes that follow our naming
convention (e.g. "s_floating_blocks_wrapper" for "s_floating_blocks"
snippet). This made maintaining the whitelist tedious and error prone.
The change enables proper enforcement of our conventions while
simplifying whitelist maintenance: a snippet subclass starting with "s_"
should be prefixed by the main snippet class name (e.g.
"s_super_snippet_item" might be added on an inner element of
"s_super_snippet"). The test just checks any element class is
prefixed by any class of any parent (or itself) (for "s_" classes).
Related to task-4373543
closesodoo/design-themes#1054
Related: odoo/odoo#189299
Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>
This allows more flexibility on the use of `align-self-*-*` classes
combination to better handle responsiveness in some scenario.
Related to task-4373543
Part-of: odoo/design-themes#1054
Related: odoo/odoo#189299
Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>
The snippet was switched to grid mode in this theme but the padding
classes on columns were not removed.
Related to task-4373543
Part-of: odoo/design-themes#1054
Related: odoo/odoo#189299
Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>
This commit adds a line within the `new_page_templates` test in order to
allow the snippet `s_rating` to be used with `s_rating_no_title`.
task-4306631
closesodoo/design-themes#1041
Related: odoo/odoo#186130
Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>
*: loftspace, real_estate
In commit [1], the test for the "Loftspace" and "Real Estate" themes has
been disabled, as their tour was not working.
This commit fixes the tours and reenables the test for these themes. The
issue was coming from the fact that they were trying to drop more
snippets than there really are, which made an acces to the array at an
inexisting index.
[1]: https://github.com/odoo/design-themes/commit/04f90cd883826bb8e4cbf8975aff6c14bf3c64dbclosesodoo/design-themes#978
X-original-commit: 4c3d843615
Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>
This commit adds a test that highlights mismatches in grid-related
options (classes, grid-area style...).
It also fixes the remaining issues in themes about it.
task-4213996
closesodoo/design-themes#971
X-original-commit: cf227cd139
Related: odoo/odoo#182039
Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>
Also disable the two theme tours that currently do not pass (for some
reason, they are not even starting at all). To fix later.
X-original-commit: 04f90cd883
Part-of: odoo/design-themes#971
Related: odoo/odoo#182039
Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>
This commit adds a test that makes sure that inline styles do not
contain the same property several times.
task-4206845
closesodoo/design-themes#946
X-original-commit: 199bd53c11
Related: odoo/odoo#181550
Signed-off-by: Alice Gaudon (agau) <agau@odoo.com>
This commit adds a test that verifies that a specific `separator` is
used when an `attribute` tag is used with either `add` or `remove`.
task-4206845
X-original-commit: 6d1a98775e
Part-of: odoo/design-themes#946
Related: odoo/odoo#181550
Signed-off-by: Alice Gaudon (agau) <agau@odoo.com>
Some snippet may come with the `fa-stack` class which breaks the
design-themes tests.
task-4156290
Part of: task-4077427
Part-of: odoo/design-themes#919
Related: odoo/odoo#180736
Signed-off-by: Benjamin Vray (bvr) <bvr@odoo.com>
Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>
This commit adapts the classes whitelist in `test_new_page_templates.py`
based on the new classes added during the dynamic snippets redesign.
task-3097273
closesodoo/design-themes#897
Related: odoo/odoo#135509
Related: odoo/enterprise#68754
Signed-off-by: Robin Lejeune (role) <role@odoo.com>
This commit adds a test to ensure that assets and images referenced from
a theme do actually belong to that theme.
task-4146886
Part-of: odoo/design-themes#889
Signed-off-by: Arthur Detroux (ard) <ard@odoo.com>
Following the change in the way of dragging and dropping a snippet onto
the page (by selecting it from a dialog displaying the actual previews
of snippets). The themes tours have been adapted to this change in this
commit.
task-3919405
closesodoo/design-themes#817
Related: odoo/odoo#166967
Related: odoo/enterprise#66150
Signed-off-by: Robin Lejeune (role) <role@odoo.com>
The following commit [1] added a test to verify that there are no
duplicate classes in the elements of predefined page templates.
This test worked fine until it failed when we attempted to merge a
commit in which a template is rendered with empty spaces in the class
attribute of an element. The test considered the empty spaces as classes
and therefore assumed that two identical classes existed.
This commit excludes empty spaces when retrieving classes in this test.
[1]: https://github.com/odoo/design-themes/commit/758e2ab819df37c56103b1e82f1e6358b3dba00c
task-3662985
closesodoo/design-themes#792
X-original-commit: 05cfe05280
Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>
Signed-off-by: Benjamin Vray (bvr) <bvr@odoo.com>
Commit [1] introduced a new test that uninstalls theme_buzzy. This leads
to the whole module being uninstalled because this module has all themes
as dependencies.
To fix this, we just run the test as the last test, ensuring the module
is still installed for other tests.
Ideally, tests would be independent from one another, but for now, the
order matters.
[1]: https://github.com/odoo/design-themes/commit/4cdd1db20c021ebd369b46c739591def9732eec5closesodoo/design-themes#782
X-original-commit: 45e9374699
Signed-off-by: Soukéina Bojabza (sobo) <sobo@odoo.com>
This commit adds a test that makes sure templates can be rendered on
all themes and that they neither contain duplicate classes nor
contradicting ones.
Covered templates:
- snippet blocks
- configurator snippet customizations
- new page template snippet customizations
task-3562147
closesodoo/design-themes#744
X-original-commit: 758e2ab819
Related: odoo/odoo#141074
Signed-off-by: Romain Derie (rde) <rde@odoo.com>
This commit removes the tooltips shown when hovering over a theme in
the website switcher dropdown. This feature will be reimplemented later,
patching the WebsiteSwitcherSystray component.
It also adapts the ?fw= url parameter to force a website id during the
tours.
task-2687506
closesodoo/design-themes#572
Related: odoo/odoo#89223
Related: odoo/enterprise#28448
Related: odoo/upgrade#3464
Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>
Now, `_post_copy()` is only called when the module is installed for the
first time on a website, not when the module is updated.
See counterpart commit in community for more details.
opw-2824045
closesodoo/design-themes#571
X-original-commit: 0e324061d1
Related: odoo/odoo#93109
Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>
Signed-off-by: Romain Derie (rde) <rde@odoo.com>
This is a backport of [1] which at the same time finally enables the
test to be able to test all theme tours. Notice that the tours should
be improved so that each step properly checks that the previous step
actually had an effect (as those tours are normally made to display to
the user and were not designed for testing). However, this is already
really useful as only checking if *entering* edit mode in each theme
does not crash is already covering most issues that can be created when
designing a theme at the moment.
[1]: https://github.com/odoo/design-themes/commit/52fef46388ec880af78c5a5f3e6152c4510548f4closesodoo/design-themes#535
X-original-commit: 208f6134a6
Signed-off-by: Romain Derie (rde) <rde@odoo.com>
Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>
Benjamin Vray