The snippet was switched to grid mode in this theme but the padding
classes on columns were not removed.
Related to task-4373543
Part-of: odoo/design-themes#1054
Related: odoo/odoo#189299
Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>
*: artists, cobalt, enark, graphene, kea, kiddo, loftspace, monglia, nano,
notes, odoo_experts, orchid, paptic, real_estate, vehicle, yes
Steps to reproduce:
1. Enable a second language in the website (e.g., French).
2. Add a "Text" block (in edit mode) > Save the page.
3. Translate a text paragraph to french > Save.
4. In edit mode again, add a link to a word in the paragraph > Save.
5. The translation in French is lost, and sometimes the whole French
translation is used for the text before or after the link.
This is actually a limitation in the translation implementation. If we
initially have `text_1_en text_2_en text_3_en` translated to French this
way:
terms en_US: `["text_1_en text_2_en text_3_en"]`
terms fr_BE: `["text_1_fr text_2_fr text_3_fr"]`
After adding a link: `text_1_en<a...>text_2_en</a>text_3_en`, and since
the links are not translated as a whole, we should get:
terms en_US: `["text_1_en", "text_2_en", "text_3_en"]`
terms fr_BE: `["text_1_fr text_2_fr text_3_fr"]`
Which means the current translation will be lost, and the result will
depend on the outcome of `get_close_matches()`. Which explains why when
the link is added to the first words of the paragraph, the system still
maps the rest of the paragraph to its "full old translation".
The goal of this commit is to make this behavior less aggressive by
forcing the links added in paragraphs [1] to be translated as a whole.
This way, the `get_close_matches()` will map the new content with a link
to its old translation (without a link), and then, the user can set the
link in the "the most meaningful part of the translation" in the
translate mode.
[1]: We should use the "translate as a whole" feature carefully with
links, since there are already some situations where it's causing
issues (see the fix in [2]). So we only force them inside paragraphs.
[2]: https://github.com/odoo/odoo/commit/9bd60ca93510e410a0136b8b433f596330900593
Remark: This commit also sets the `o_translate_inline` class by default
on paragraph links in website templates.
opw-3984439
closesodoo/design-themes#1055
Related: odoo/odoo#204453
Signed-off-by: Outagant Mehdi (mou) <mou@odoo.com>
*: theme_bewise, theme_cobalt, theme_kiddo, theme_loftspace,
theme_monglia, theme_nano, theme_notes, theme_odoo_experts,
theme_orchid, theme_paptic, theme_yes, theme_zap
Multiple snippet template where changed to ensure that the title is not
considered as a column and allowing changing the nb of columns again.
This commit adapts all the xpath that were impacted by those changes.
task-4310468
closesodoo/design-themes#1047
Related: odoo/odoo#195409
Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>
*: anelusia, artists, avantgarde, aviato, beauty, bewise, bistro,
bookstore, buzzy, clean, cobalt, enark, graphene, kea, kiddo, loftspace,
monglia, nano, notes, odoo_experts, orchid, paptic, real_estate,
treehouse, vehicle, yes, zap
This commit aims to fix a wrong implementation of gradients on the
`s_big_number` snippet within the context of the web editor.
Prior to this commit, the `s_big_number` snippet was using a gradient
composed of the right color, but being declared as `RGB` values.
While this is working as expected and looking like it uses the right
`--o-color-*`, it's indeed working with the specific color applied in
first place. If a user changes the color palette of the website, the
snippet will look terrible as it doesn't adapt to the new palette.
This commit fixes the issue by using the right implementation with CSS
variables.
It also reviews a wrong structure using `<div>` while it should use the
right html tag.
task-4202371
closesodoo/design-themes#930
Related: odoo/odoo#180983
Signed-off-by: Benjamin Vray (bvr) <bvr@odoo.com>
*: avantgarde, aviato, beauty, bewise, bistro,bookstore, buzzy, clean,
cobalt, kea, kiddo, monglia, nano, notes, Orchid, paptic, real_estate,
vehicle, yes, zap
This commit adapts the design of `s_company_team_card` for multiple
themes, based on the new Odoo 18 snippet redesign.
task-4149441
closesodoo/design-themes#902
Part-of: task-4077427
Related: odoo/odoo#179843
Signed-off-by: Christopher du Toit (chto) <chto@odoo.com>
*: nano, notes, odoo_experts, treehouse, zap
This commit reviews the occurrences of the `s_numbers_*` snippets
to align them with the new layout of these snippets.
Prior to this commit, the layout of those snippet was "broken" due to
weird structure like nested rows, .. which prevents the editor to apply
a change on the whole content.
As we reworked the layout of these snippets to fix the issue, we need to
apply these changes in themes as well.
task-4223179
closesodoo/design-themes#1012
Related: odoo/odoo#185688
Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>
Currently, an error occurs while importing an 'Experts' theme template.
Steps to produce:
- Install the 'website' module.
- Build one website, try to switch its theme to the 'Experts' theme.
ValueError:
External ID not found in the system: website.configurator_s_picture
When switching a website theme to the 'Experts' theme, an error occurs
during importing their XML definition because their parent template does
not exist. To resolve this issue we can remove this template.
Indeed, that configurator snippet override was not needed anymore since
the 'Experts' theme was not using that specific snippet for their
configurator pages anymore. The error went unnoticed because on runbot
all themes are installed, and at least one of them was using that
specific snippet in a configurator page. This will be improved.
See [1] with the same kind of issue.
[1]: https://github.com/odoo/design-themes/commit/aed6d0585be5c646e1c3cade419c706dc154efaf
Sentry-5962594281
closesodoo/design-themes#990
X-original-commit: 6336bbddf6
Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>
*: anelusia, avantgarde, beauty, bistro, bookstore, enark, kiddo,
loftspace, monglia, nano, notes, odoo_experts, paptic, real_estate,
treehouse, yes, zap
In the community PR, the `s_card_offset` snippet has been modified in
order to not be in `display: flex` anymore. The visual was then kept as
close as possible to how it was before by using the grid padding.
This commit adapts this snippet customizations to these changes. More
precisely, it adapts the vertical padding to the text content, in order
to center it a bit while avoiding having an overflow.
Related to task-4105038
X-original-commit: 127a07fdc5
Part-of: odoo/design-themes#955
Related: odoo/odoo#181816
Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>
Signed-off-by: Soukéina Bojabza (sobo) <sobo@odoo.com>
This commit has two main goals:
1. Adapt the copy of the `s_text_cover` snippet to fit each theme
2. Introduce custom images for each themes, as the `s_text_cover` was
always using the same image until now
This commit also fixes some conflicting classes due to a change of
`background-color` in the default snippet.
task-4119904
Part of task-3619705
Part-of: odoo/design-themes#919
Related: odoo/odoo#180736
Signed-off-by: Benjamin Vray (bvr) <bvr@odoo.com>
Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>
This commit adapts the xpath for the `s_key_benefits` snippet that were
targeting `col-lg-4`.
As we switched the layout of this snippet to columns, we reviewed the
layout a bit, resulting in one single `col-12` on top, rather than
`col-4` and `col-12`.
As we remove this `col-lg-4`, we need to adapt all the xpaths.
task-4188740
Part of task-4077427
Part-of: odoo/design-themes#919
Related: odoo/odoo#180736
Signed-off-by: Outagant Mehdi (mou) <mou@odoo.com>
Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>
Commit [1] adapted the "Image Gallery" new design for the different
themes. In the `notes` and `odoo_experts` themes, the `s_image_gallery_
indicators_arrows_boxed` class was added, in order to have squared
arrows. However, this class does not exist, as the correct one is
`s_image_gallery_arrows_boxed`. This made the arrows stay as the default
ones in these themes.
Moreover, the default arrow class `s_image_gallery_arrows_default` was
not removed in the xpath, making the two classes coexist.
This commit fixes these class issues.
[1]: https://github.com/odoo/design-themes/commit/f66833de41f757c65ecf660f7bbc033b6dc64d6a
Related to task-3654328
closesodoo/design-themes#909
Related: odoo/odoo#180238
Signed-off-by: Colin Louis (loco) <loco@odoo.com>
*: theme_aviato, theme_monglia, theme_odoo_experts, theme_real_estate,
theme_yes
Since the removal of `container` divs in the `s_quotes_carousel`
snippet, this commit adapts the theme customizations.
This commit also fixes contrast issues related to the "Invert colors"
option.
task-4167538
Part of task-3619705
closesodoo/design-themes#898
Related: odoo/odoo#179389
Signed-off-by: Benjamin Vray (bvr) <bvr@odoo.com>
*: artists, avantgarde, aviato, bookstore, buzzy, clean, graphene, kea,
kiddo, loftspace, monglia, odoo_experts, orchid, paptic, real_estate,
vehicle
This commit mirrors the changes made to the `s_three_columns` and the
`s_comparisons` snippets, adding the use of the `s_card` snippet in them
in the community counterpart.
task-4115012
part of task-3619705
closesodoo/design-themes#868
Related: odoo/odoo#176684
Signed-off-by: Soukéina Bojabza (sobo) <sobo@odoo.com>
Some snippets contain incorrect font style that are not achievable using
the editor (for example: <h2 class="display-3"> in the "Key benefits"
snippet).
These snippets were adapted in the community commit linked to this one
to align with what the editor would generate if we recreated them from
scratch.
In this commit, we adapt the themes following the change in community.
We also fix a few issues (e.g., wording for the ´s_numbers´ snippet)
noticed during the changes.
task-4148057
closesodoo/design-themes#895
Related: odoo/odoo#178957
Signed-off-by: Robin Lejeune (role) <role@odoo.com>
*: theme_buzzy, theme_cobalt, theme_kea, theme_nano, theme_odoo_experts,
theme_paptic, theme_vehicle, theme_zap
The goal of this commit is to fix xpath after the `s_references` snippet
redesign, and eventually tweak some classes.
task-3668033
closesodoo/design-themes#838
Related: odoo/odoo#163837
Signed-off-by: Soukéina Bojabza (sobo) <sobo@odoo.com>
stefanorigano (SRI)