*: artists, cobalt, enark, graphene, kea, kiddo, loftspace, monglia, nano,
notes, odoo_experts, orchid, paptic, real_estate, vehicle, yes
Steps to reproduce:
1. Enable a second language in the website (e.g., French).
2. Add a "Text" block (in edit mode) > Save the page.
3. Translate a text paragraph to french > Save.
4. In edit mode again, add a link to a word in the paragraph > Save.
5. The translation in French is lost, and sometimes the whole French
translation is used for the text before or after the link.
This is actually a limitation in the translation implementation. If we
initially have `text_1_en text_2_en text_3_en` translated to French this
way:
terms en_US: `["text_1_en text_2_en text_3_en"]`
terms fr_BE: `["text_1_fr text_2_fr text_3_fr"]`
After adding a link: `text_1_en<a...>text_2_en</a>text_3_en`, and since
the links are not translated as a whole, we should get:
terms en_US: `["text_1_en", "text_2_en", "text_3_en"]`
terms fr_BE: `["text_1_fr text_2_fr text_3_fr"]`
Which means the current translation will be lost, and the result will
depend on the outcome of `get_close_matches()`. Which explains why when
the link is added to the first words of the paragraph, the system still
maps the rest of the paragraph to its "full old translation".
The goal of this commit is to make this behavior less aggressive by
forcing the links added in paragraphs [1] to be translated as a whole.
This way, the `get_close_matches()` will map the new content with a link
to its old translation (without a link), and then, the user can set the
link in the "the most meaningful part of the translation" in the
translate mode.
[1]: We should use the "translate as a whole" feature carefully with
links, since there are already some situations where it's causing
issues (see the fix in [2]). So we only force them inside paragraphs.
[2]: https://github.com/odoo/odoo/commit/9bd60ca93510e410a0136b8b433f596330900593
Remark: This commit also sets the `o_translate_inline` class by default
on paragraph links in website templates.
opw-3984439
closesodoo/design-themes#1055
Related: odoo/odoo#204453
Signed-off-by: Outagant Mehdi (mou) <mou@odoo.com>
Currently, an error occurs while importing an 'Experts' theme template.
Steps to produce:
- Install the 'website' module.
- Build one website, try to switch its theme to the 'Experts' theme.
ValueError:
External ID not found in the system: website.configurator_s_picture
When switching a website theme to the 'Experts' theme, an error occurs
during importing their XML definition because their parent template does
not exist. To resolve this issue we can remove this template.
Indeed, that configurator snippet override was not needed anymore since
the 'Experts' theme was not using that specific snippet for their
configurator pages anymore. The error went unnoticed because on runbot
all themes are installed, and at least one of them was using that
specific snippet in a configurator page. This will be improved.
See [1] with the same kind of issue.
[1]: https://github.com/odoo/design-themes/commit/aed6d0585be5c646e1c3cade419c706dc154efaf
Sentry-5962594281
closesodoo/design-themes#990
X-original-commit: 6336bbddf6
Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>
The goal of this commit is to fix xpath after the `s_picture` snippet
redesign, and eventually tweak some classes.
task-4047748
closesodoo/design-themes#824
Related: odoo/odoo#172740
Signed-off-by: Arthur Detroux (ard) <ard@odoo.com>
This commit extracts the pre-defined section shapes from blocks into
templates that are dedicated to being used by the configurator.
For blocks that are not used in configurator pages, the configurator
templates have not been created.
task-3381714
Part-of: odoo/design-themes#692
*: anelusia, artists, aviato, graphene, kiddo, loftspace, monglia,
notes, odoo_experts, paptic, test_custo, yes
The community PR [125824] introduces an automatic check on buttons to
add the `mb-2` class when several buttons follow each other, so that
they have space to breathe when split on multiple lines.
For consistency, this commit therefore removes most `mb-2` occurrences
on buttons within themes as long as they are alone on their line, but
keeps or adds the class when several buttons are next to each other.
[125824]: https://github.com/odoo/odoo/pull/125824
task-3369604
closesodoo/design-themes#680
Related: odoo/odoo#125824
Signed-off-by: Benjamin Vray (bvr) <bvr@odoo.com>
Initially, the background shapes were flipped using only CSS. This was
done by adding the classes 'o_we_flip_x' or 'o_we_flip_y' to a shape to
flip it. However, this system caused issues as it sometimes left a gap
between two connected shapes. As a result, the system was changed with
this commit [1], and the classes 'o_we_flip_x' and 'o_we_flip_y' were no
longer used from this point on.
Despite this change, in our themes, we continued to use these obsolete
classes to define whether a shape should be flipped or not. This commit
addresses this by removing all instances of 'o_we_flip_x' and
'o_we_flip_y' classes that were still being used in theme snippets and
replacing them with the new system, where flipping is defined as a
parameter in the background image URL.
Note that in stable versions where we cannot modify theme snippets, we
have added code to automatically adapt the shapes to the new system
(in this commit [2]).
[1]: https://github.com/odoo/odoo/commit/42b3ad10e0b32b7fc72f801e2c67d6baf938c566
[2]: https://github.com/odoo/odoo/commit/256ff539afe331544ccb58848f1ecd0eecbe4daa
task-2824607
closesodoo/design-themes#639
Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>
This commit improves the global layout of theme_odoo_experts to give
more variety with the others corporate themes (buzzy, graphene, clean,
etc.).
The purpose is to have a theme that can be used to present an
application and to promote the new category of device shapes.
task-2666049
closesodoo/design-themes#525
Related: odoo/odoo#79068
Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>
Mehdi Outagant (MOU)