*: artists, cobalt, enark, graphene, kea, kiddo, loftspace, monglia, nano,
notes, odoo_experts, orchid, paptic, real_estate, vehicle, yes
Steps to reproduce:
1. Enable a second language in the website (e.g., French).
2. Add a "Text" block (in edit mode) > Save the page.
3. Translate a text paragraph to french > Save.
4. In edit mode again, add a link to a word in the paragraph > Save.
5. The translation in French is lost, and sometimes the whole French
translation is used for the text before or after the link.
This is actually a limitation in the translation implementation. If we
initially have `text_1_en text_2_en text_3_en` translated to French this
way:
terms en_US: `["text_1_en text_2_en text_3_en"]`
terms fr_BE: `["text_1_fr text_2_fr text_3_fr"]`
After adding a link: `text_1_en<a...>text_2_en</a>text_3_en`, and since
the links are not translated as a whole, we should get:
terms en_US: `["text_1_en", "text_2_en", "text_3_en"]`
terms fr_BE: `["text_1_fr text_2_fr text_3_fr"]`
Which means the current translation will be lost, and the result will
depend on the outcome of `get_close_matches()`. Which explains why when
the link is added to the first words of the paragraph, the system still
maps the rest of the paragraph to its "full old translation".
The goal of this commit is to make this behavior less aggressive by
forcing the links added in paragraphs [1] to be translated as a whole.
This way, the `get_close_matches()` will map the new content with a link
to its old translation (without a link), and then, the user can set the
link in the "the most meaningful part of the translation" in the
translate mode.
[1]: We should use the "translate as a whole" feature carefully with
links, since there are already some situations where it's causing
issues (see the fix in [2]). So we only force them inside paragraphs.
[2]: https://github.com/odoo/odoo/commit/9bd60ca93510e410a0136b8b433f596330900593
Remark: This commit also sets the `o_translate_inline` class by default
on paragraph links in website templates.
opw-3984439
closesodoo/design-themes#1055
Related: odoo/odoo#204453
Signed-off-by: Outagant Mehdi (mou) <mou@odoo.com>
*: anelusia, artists, avantgarde, aviato, beauty, bewise, bistro,
bookstore, buzzy, clean, cobalt, enark, graphene, kea, kiddo, loftspace,
monglia, nano, notes, odoo_experts, orchid, paptic, real_estate,
treehouse, vehicle, yes, zap
This commit aims to fix a wrong implementation of gradients on the
`s_big_number` snippet within the context of the web editor.
Prior to this commit, the `s_big_number` snippet was using a gradient
composed of the right color, but being declared as `RGB` values.
While this is working as expected and looking like it uses the right
`--o-color-*`, it's indeed working with the specific color applied in
first place. If a user changes the color palette of the website, the
snippet will look terrible as it doesn't adapt to the new palette.
This commit fixes the issue by using the right implementation with CSS
variables.
It also reviews a wrong structure using `<div>` while it should use the
right html tag.
task-4202371
closesodoo/design-themes#930
Related: odoo/odoo#180983
Signed-off-by: Benjamin Vray (bvr) <bvr@odoo.com>
*: avantgarde, beauty, bistro, buzzy, clean, cobalt, graphene, kea, yes
This commit adapts the style attribute's add/remove operations in order
to avoid ending up with the same property defined several times.
task-4206845
X-original-commit: 266b35a31e
Part-of: odoo/design-themes#946
Related: odoo/odoo#181550
Signed-off-by: Alice Gaudon (agau) <agau@odoo.com>
This commit has two main goals:
1. Adapt the copy of the `s_text_cover` snippet to fit each theme
2. Introduce custom images for each themes, as the `s_text_cover` was
always using the same image until now
This commit also fixes some conflicting classes due to a change of
`background-color` in the default snippet.
task-4119904
Part of task-3619705
Part-of: odoo/design-themes#919
Related: odoo/odoo#180736
Signed-off-by: Benjamin Vray (bvr) <bvr@odoo.com>
Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>
This commit adapts the xpath for the `s_key_benefits` snippet that were
targeting `col-lg-4`.
As we switched the layout of this snippet to columns, we reviewed the
layout a bit, resulting in one single `col-12` on top, rather than
`col-4` and `col-12`.
As we remove this `col-lg-4`, we need to adapt all the xpaths.
task-4188740
Part of task-4077427
Part-of: odoo/design-themes#919
Related: odoo/odoo#180736
Signed-off-by: Outagant Mehdi (mou) <mou@odoo.com>
Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>
This commit fixes a readability issue on the `s_cover` snippet.
Prior to this commit, the background was set to `o_cc4` which was quite
arbitrary, but could also create readability issues in some case.
As the image has a black filter on top of it, setting the `o_cc` class
to `o_cc5` will ensure a readable text no matter the theme/industry.
task-4190912
Part-of: odoo/design-themes#919
Related: odoo/odoo#180736
Signed-off-by: Benjamin Vray (bvr) <bvr@odoo.com>
Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>
*: artists, avantgarde, aviato, bookstore, buzzy, clean, graphene, kea,
kiddo, loftspace, monglia, odoo_experts, orchid, paptic, real_estate,
vehicle
This commit mirrors the changes made to the `s_three_columns` and the
`s_comparisons` snippets, adding the use of the `s_card` snippet in them
in the community counterpart.
task-4115012
part of task-3619705
closesodoo/design-themes#868
Related: odoo/odoo#176684
Signed-off-by: Soukéina Bojabza (sobo) <sobo@odoo.com>
Some snippets contain incorrect font style that are not achievable using
the editor (for example: <h2 class="display-3"> in the "Key benefits"
snippet).
These snippets were adapted in the community commit linked to this one
to align with what the editor would generate if we recreated them from
scratch.
In this commit, we adapt the themes following the change in community.
We also fix a few issues (e.g., wording for the ´s_numbers´ snippet)
noticed during the changes.
task-4148057
closesodoo/design-themes#895
Related: odoo/odoo#178957
Signed-off-by: Robin Lejeune (role) <role@odoo.com>
This commit reviews the occurrences of the numbers snippets across
the website themes, especially broken selector.
The goal of this commit is to fix potential broken xpath as wel as
fine-tune the design if needed.
task-3924624
Part-of: odoo/design-themes#822
Related: odoo/odoo#163583
Signed-off-by: Benoit Socias (bso) <bso@odoo.com>
*: (artists, buzzy, graphene)
This commit removes the customization of icon colors, as we are not
using them in the Odoo 18 redesign.
It also adapts the background of numbers to increase contrasts.
It also removes a title customization in the graphene theme as it was
not changing anything from the default snippet.
task-3672430
closesodoo/design-themes#840
Related: odoo/odoo#174166
Signed-off-by: Colin Louis (loco) <loco@odoo.com>
*: (anelusia, beauty, bewise, graphene, notes, yes)
This commit adapts the design of `s_company_team` for multiple themes,
based on the new Odoo 18 snippet redesign.
task-3657640
closesodoo/design-themes#844
Related: odoo/odoo#172719
Signed-off-by: Benjamin Vray (bvr) <bvr@odoo.com>
*: (artists, bookstore, cobalt, enark, graphene, monglia, real_estate,
vehicle, yes, zap)
This commit adapts the design of `s_image_wall` for multiple themes,
based on the new Odoo 18 snippet redesign.
task-3654301
closesodoo/design-themes#843
Related: odoo/odoo#163839
Signed-off-by: Robin Lejeune (role) <role@odoo.com>
This commit aims to review all the occurrences of the `s_cover`
snippet across the themes in order to fix broken selectors.
task-3665300
Part-of: odoo/design-themes#827
Related: odoo/odoo#172725
Signed-off-by: Benoit Socias (bso) <bso@odoo.com>
This commit aims to review all the occurrences of the `s_image_text`
snippet across the themes in order to fix broken selectors.
task-3665301
closesodoo/design-themes#830
Related: odoo/odoo#173311
Signed-off-by: Robin Lejeune (role) <role@odoo.com>
This commit aims to review all the occurrences of the `s_text_image`
snippet across the themes in order to fix broken selectors.
task-3665301
Part-of: odoo/design-themes#830
Related: odoo/odoo#173311
Signed-off-by: Robin Lejeune (role) <role@odoo.com>
Mehdi Outagant (MOU)