Commit Graph

8 Commits

Author SHA1 Message Date
Mehdi Outagant (MOU) bd8ff4cb1d [FIX] theme_*: translate paragraph links as a whole.
*: artists, cobalt, enark, graphene, kea, kiddo, loftspace, monglia, nano,
notes, odoo_experts, orchid, paptic, real_estate, vehicle, yes

Steps to reproduce:

1. Enable a second language in the website (e.g., French).

2. Add a "Text" block (in edit mode) > Save the page.

3. Translate a text paragraph to french > Save.

4. In edit mode again, add a link to a word in the paragraph > Save.

5. The translation in French is lost, and sometimes the whole French
    translation is used for the text before or after the link.

This is actually a limitation in the translation implementation. If we
initially have `text_1_en text_2_en text_3_en` translated to French this
way:

terms en_US: `["text_1_en text_2_en text_3_en"]`
terms fr_BE: `["text_1_fr text_2_fr text_3_fr"]`

After adding a link: `text_1_en<a...>text_2_en</a>text_3_en`, and since
the links are not translated as a whole, we should get:

terms en_US: `["text_1_en", "text_2_en", "text_3_en"]`
terms fr_BE: `["text_1_fr text_2_fr text_3_fr"]`

Which means the current translation will be lost, and the result will
depend on the outcome of `get_close_matches()`. Which explains why when
the link is added to the first words of the paragraph, the system still
maps the rest of the paragraph to its "full old translation".

The goal of this commit is to make this behavior less aggressive by
forcing the links added in paragraphs [1] to be translated as a whole.
This way, the `get_close_matches()` will map the new content with a link
to its old translation (without a link), and then, the user can set the
link in the "the most meaningful part of the translation" in the
translate mode.

[1]: We should use the "translate as a whole" feature carefully with
links, since there are already some situations where it's causing
issues (see the fix in [2]). So we only force them inside paragraphs.

[2]: https://github.com/odoo/odoo/commit/9bd60ca93510e410a0136b8b433f596330900593

Remark: This commit also sets the `o_translate_inline` class by default
on paragraph links in website templates.

opw-3984439

closes odoo/design-themes#1055

Related: odoo/odoo#204453
Signed-off-by: Outagant Mehdi (mou) <mou@odoo.com>
2025-04-14 09:28:47 +00:00
stefanorigano (SRI) 57cf8bb724 [IMP] theme_bookstore, *: adapt to new s_masonry_block design
*: theme_notes, theme_real_estate, theme_yes, theme_zap, theme_vehicle

Along with xPath adaptations, this commit also replaces a pixelated
image in the 'theme_yes'.

task-3665303
part of task-3619705

closes odoo/design-themes#839

Related: odoo/odoo#173870
Signed-off-by: Soukéina Bojabza (sobo) <sobo@odoo.com>
2024-08-07 10:00:54 +00:00
Romain Derie 9c23ffc98d [IMP] themes_*: rewrite some messages and fix typos
Themes translation in Odoo 16 have been lost, they were not exported on
Transifex anymore (bug).

We just added back the repository on it, and our internal translators
are working on those translations.

They found some typos and bad wording which are fixed here.

Technically, note that we need the themes fully translated for the
chatGPT integration coming in website configurator.
Indeed, if a theme is not (almost fully) translated, it won't be using
chatGPT for text replacement.
This is because if we ask chatGPT to do text replacement and translation
at the same time, it just provides bad results.
See https://github.com/odoo/odoo/pull/137703

closes odoo/design-themes#725

X-original-commit: 7cdb6d2ab7
Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>
Signed-off-by: Romain Derie (rde) <rde@odoo.com>
2023-10-18 07:51:44 +00:00
can-odoo 9cca23373e [IMP] theme_yes: change description of masonry snippet
Introduced with [1], same description for Caterers and Venues block.

[1]: https://github.com/odoo/design-themes/commit/299d504df31bf179775eec1d37e71605c3637460

task-2994239

closes odoo/design-themes#647

X-original-commit: 57de963baf
Signed-off-by: Romain Derie (rde) <rde@odoo.com>
2023-04-17 18:01:32 +02:00
Soukéina Bojabza 628880b71b [IMP] theme_*: adapt some themes to the grid-only Masonry snippet
The Masonry snippet has been modified to be only in grid mode
and its templates have therefore been changed.

This commit adapts the themes that modify the Masonry templates to be
in accordance with these changes.

See community counterpart for details.

task-2973198

closes odoo/design-themes#601

X-original-commit: ef84cdf84d
Related: odoo/odoo#102525
Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>
2022-10-06 23:14:30 +02:00
Elisabeth Dickinson 299d504df3 [IMP] theme_yes: update the theme
This commit updates the theme to improve the design with new colors, new
pictures and new snippet customizations.

task-2555035

X-original-commit: 2a2da47270
Part-of: odoo/design-themes#501
2021-09-24 11:09:52 +00:00
Sébastien Mottet (oms) 57e63ad290 [FIX] theme_*: fix masonry xpath
*: vehicle, yes, zap

Commit [1] modified the website.s_masonry_block template and makes it
call website.s_masonry_block_default_template. The theme custo xpaths
should now be done in that template instead.

[1]: https://github.com/odoo/odoo/commit/c90ab7b6646b603dcd0a49387b5eeba60ce17f59

closes odoo/design-themes#493

Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>
2021-09-03 10:38:08 +00:00
Jeremy Kersten cb1e3be3f8 [ADD] theme 14.0 2021-05-10 15:45:35 +02:00