Commit Graph

8 Commits

Author SHA1 Message Date
Mehdi Outagant (MOU) bd8ff4cb1d [FIX] theme_*: translate paragraph links as a whole.
*: artists, cobalt, enark, graphene, kea, kiddo, loftspace, monglia, nano,
notes, odoo_experts, orchid, paptic, real_estate, vehicle, yes

Steps to reproduce:

1. Enable a second language in the website (e.g., French).

2. Add a "Text" block (in edit mode) > Save the page.

3. Translate a text paragraph to french > Save.

4. In edit mode again, add a link to a word in the paragraph > Save.

5. The translation in French is lost, and sometimes the whole French
    translation is used for the text before or after the link.

This is actually a limitation in the translation implementation. If we
initially have `text_1_en text_2_en text_3_en` translated to French this
way:

terms en_US: `["text_1_en text_2_en text_3_en"]`
terms fr_BE: `["text_1_fr text_2_fr text_3_fr"]`

After adding a link: `text_1_en<a...>text_2_en</a>text_3_en`, and since
the links are not translated as a whole, we should get:

terms en_US: `["text_1_en", "text_2_en", "text_3_en"]`
terms fr_BE: `["text_1_fr text_2_fr text_3_fr"]`

Which means the current translation will be lost, and the result will
depend on the outcome of `get_close_matches()`. Which explains why when
the link is added to the first words of the paragraph, the system still
maps the rest of the paragraph to its "full old translation".

The goal of this commit is to make this behavior less aggressive by
forcing the links added in paragraphs [1] to be translated as a whole.
This way, the `get_close_matches()` will map the new content with a link
to its old translation (without a link), and then, the user can set the
link in the "the most meaningful part of the translation" in the
translate mode.

[1]: We should use the "translate as a whole" feature carefully with
links, since there are already some situations where it's causing
issues (see the fix in [2]). So we only force them inside paragraphs.

[2]: https://github.com/odoo/odoo/commit/9bd60ca93510e410a0136b8b433f596330900593

Remark: This commit also sets the `o_translate_inline` class by default
on paragraph links in website templates.

opw-3984439

closes odoo/design-themes#1055

Related: odoo/odoo#204453
Signed-off-by: Outagant Mehdi (mou) <mou@odoo.com>
2025-04-14 09:28:47 +00:00
mano-odoo 23b2dd1971 [IMP] theme_artists: revamp the theme
Revamp the themes, add new images and adapt the existing snippets to fit
the new design.

task-4178014
Part of task-4177975

X-original-commit: 14993a5a1e
Part-of: odoo/design-themes#971
Related: odoo/odoo#182039
Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>
2024-09-30 16:38:13 +00:00
Brieuc-brd f66833de41 [IMP] test_themes, *: carousels adaptations
*: theme_anelusia, theme_artists, theme_avantgarde, theme_cobalt,
theme_cobalt, theme_enark, theme_loftspace, theme_notes,
theme_odoo_experts, theme_bewise, theme_bistro, theme_buzzy,
theme_clean, theme_graphene, theme_nano, theme_treehouse, theme_yes,
theme_aviato, theme_beauty, theme_bookstore, theme_kea, theme_kiddo,
theme_monglia, theme_orchid, theme_paptic, theme_real_estate,
theme_vehicle, theme_zap

This commit adapts the customizations related to `s_carousel`,
s_image_gallery` and `s_quotes_carousel` since these snippets has been
redesigned in PR[1].

task-3654328
Part of task-3619705

[1]: https://github.com/odoo/odoo/pull/172727

closes odoo/design-themes#836

Related: odoo/odoo#172727
Signed-off-by: Benoit Socias (bso) <bso@odoo.com>
2024-08-27 08:18:59 +00:00
Benoit Socias 76e9cbcdb6 [FIX] theme_*: remove duplicate and conflicting classes
When default snippets have been updated to rely on color presets ([1]),
some themes were not adapted accordingly.
This also happened whenever paddings of base blocks were modified.
Because of this there are elements in themes for which some classes are
applied several times, and some where classes are not removed before
adding a contradicting one.

This commit adjusts the classes so that themes neither:
- produce snippets with duplicated classes
- produce snippets with contradicting classes (e.g. two different
bottom paddings on the same element)

This commit also fixes a typo from [2] which was the source of
duplicate classes.

[1]: https://github.com/odoo/odoo/commit/5953c4df6b9c08519f64a65c1cf5d5558d59f7d4
[2]: https://github.com/odoo/design-themes/commit/299d504df31bf179775eec1d37e71605c3637460#diff-86c142838104de06e89f629c51cf791464538dc8899e6a3f00c24f69638db409R34

task-3562147

X-original-commit: f3da06dc68
Part-of: odoo/design-themes#744
2023-11-05 04:52:43 +00:00
Benoit Socias d206c11972 [IMP] theme_*: extract shapes to configurator-dedicated templates
This commit extracts the pre-defined section shapes from blocks into
templates that are dedicated to being used by the configurator.

For blocks that are not used in configurator pages, the configurator
templates have not been created.

task-3381714

Part-of: odoo/design-themes#692
2023-10-14 03:27:02 +00:00
Robin Lejeune (role) a86d9f73df [FIX] theme_*: remove mb-2 class on orphan buttons
*: anelusia, artists, aviato, graphene, kiddo, loftspace, monglia,
notes, odoo_experts, paptic, test_custo, yes

The community PR [125824] introduces an automatic check on buttons to
add the `mb-2` class when several buttons follow each other, so that
they have space to breathe when split on multiple lines.
For consistency, this commit therefore removes most `mb-2` occurrences
on buttons within themes as long as they are alone on their line, but
keeps or adds the class when several buttons are next to each other.

[125824]: https://github.com/odoo/odoo/pull/125824

task-3369604

closes odoo/design-themes#680

Related: odoo/odoo#125824
Signed-off-by: Benjamin Vray (bvr) <bvr@odoo.com>
2023-08-03 19:30:56 +02:00
Benjamin Vray 44b3badbca [FIX] theme_*: remove flip classes from theme snippets
Initially, the background shapes were flipped using only CSS. This was
done by adding the classes 'o_we_flip_x' or 'o_we_flip_y' to a shape to
flip it. However, this system caused issues as it sometimes left a gap
between two connected shapes. As a result, the system was changed with
this commit [1], and the classes 'o_we_flip_x' and 'o_we_flip_y' were no
longer used from this point on.

Despite this change, in our themes, we continued to use these obsolete
classes to define whether a shape should be flipped or not. This commit
addresses this by removing all instances of 'o_we_flip_x' and
'o_we_flip_y' classes that were still being used in theme snippets and
replacing them with the new system, where flipping is defined as a
parameter in the background image URL.

Note that in stable versions where we cannot modify theme snippets, we
have added code to automatically adapt the shapes to the new system
(in this commit [2]).

[1]: https://github.com/odoo/odoo/commit/42b3ad10e0b32b7fc72f801e2c67d6baf938c566
[2]: https://github.com/odoo/odoo/commit/256ff539afe331544ccb58848f1ecd0eecbe4daa

task-2824607

closes odoo/design-themes#639

Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>
2023-04-07 19:43:08 +02:00
Brieuc-brd 30c3b2cdae [IMP] theme_artists: update the theme
This commit updates the theme to improve the design with new colors, new
pictures and new snippet customizations.

task-2580170

X-original-commit: 46a1d66d96
Part-of: odoo/design-themes#501
2021-09-24 11:09:42 +00:00