From 12e78e95ec731b45e3929114cdbe571d907ad32c Mon Sep 17 00:00:00 2001
From: Victor Feyens <vfe@odoo.com>
Date: Thu, 4 Feb 2021 17:46:47 +0100
Subject: [PATCH] bring back analytics logic in layout template

---
 extensions/odoo_theme/layout.html                      |  4 +---
 .../odoo_theme/layout_templates/google_analytics.html  | 10 ++++++++++
 extensions/odoo_theme/static/js/google_analytics.js    |  9 ---------
 3 files changed, 11 insertions(+), 12 deletions(-)
 create mode 100644 extensions/odoo_theme/layout_templates/google_analytics.html
 delete mode 100644 extensions/odoo_theme/static/js/google_analytics.js

diff --git a/extensions/odoo_theme/layout.html b/extensions/odoo_theme/layout.html
index d7ccf8a38..f2723173e 100644
--- a/extensions/odoo_theme/layout.html
+++ b/extensions/odoo_theme/layout.html
@@ -51,9 +51,7 @@
 #}
 {% block footer %}
     {%- if google_analytics_key -%}
-        {# FIXME VFE bring back old logic, it cannot be specified in a js file. #}
-        <script type="text/javascript"
-                src="{{ pathto('_static/js/google_analytics.js', 1) }}"></script>
+        {% include "layout_templates/google_analytics.html" %}
     {%- endif -%}
 {% endblock %}
 
diff --git a/extensions/odoo_theme/layout_templates/google_analytics.html b/extensions/odoo_theme/layout_templates/google_analytics.html
new file mode 100644
index 000000000..a6c47d42d
--- /dev/null
+++ b/extensions/odoo_theme/layout_templates/google_analytics.html
@@ -0,0 +1,10 @@
+<script>
+    (function(i,s,o,g,r,a,m){i['GoogleAnalyticsObject']=r;i[r]=i[r]||function(){
+    (i[r].q=i[r].q||[]).push(arguments)},i[r].l=1*new Date();a=s.createElement(o),
+    m=s.getElementsByTagName(o)[0];a.async=1;a.src=g;m.parentNode.insertBefore(a,m)
+    })(window,document,'script','//www.google-analytics.com/analytics.js','ga');
+
+    ga('create', '{{ google_analytics_key }}', 'auto');
+    ga('set', 'anonymizeIp', true);
+    ga('send','pageview');
+</script>
diff --git a/extensions/odoo_theme/static/js/google_analytics.js b/extensions/odoo_theme/static/js/google_analytics.js
deleted file mode 100644
index 5630c5fb2..000000000
--- a/extensions/odoo_theme/static/js/google_analytics.js
+++ /dev/null
@@ -1,9 +0,0 @@
-(function(i,s,o,g,r,a,m){i['GoogleAnalyticsObject']=r;i[r]=i[r]||function(){
-    (i[r].q=i[r].q||[]).push(arguments)},i[r].l=1*new Date();a=s.createElement(o),
-    m=s.getElementsByTagName(o)[0];a.async=1;a.src=g;m.parentNode.insertBefore(a,m)
-})(window,document,'script','//www.google-analytics.com/analytics.js','ga');
-
-// VFE FIXME, the {{}} is jinja code, it cannot be moved in an independent js code :P
-ga('create', '{{ google_analytics_key }}', 'auto');
-ga('set', 'anonymizeIp', true);
-ga('send','pageview');
\ No newline at end of file