From 8a0f371531c38cab59ea81d22e82f0c0ce4ea40a Mon Sep 17 00:00:00 2001
From: Arnaud Joset <arj@odoo.com>
Date: Thu, 6 Feb 2020 13:37:33 +0100
Subject: [PATCH] [IMP] technical: remove warning about scripts assets

Before this commit, the following warning was displayed at compilation: "RemovedInSphinx30Warning: To modify script_files in the theme is deprecated. Please insert a <script> tag directly in your theme instead."
---
 _extensions/odoo/layout.html   | 14 +++++++-------
 _extensions/odoo/translator.py |  7 ++++++-
 2 files changed, 13 insertions(+), 8 deletions(-)

diff --git a/_extensions/odoo/layout.html b/_extensions/odoo/layout.html
index 6eba82ada..4c80ed1a3 100644
--- a/_extensions/odoo/layout.html
+++ b/_extensions/odoo/layout.html
@@ -1,11 +1,11 @@
 {% extends "basic/layout.html" %}
-
-{% set script_files = script_files + [
-'_static/jquery.min.js',
-'_static/bootstrap.js',
-'_static/doc.js',
-'_static/jquery.noconflict.js',
-] %}
+{%- block scripts %}
+ {{ super() }}
+<script type="text/javascript" src="{{ pathto('_static/jquery.min.js', 1) }}"></script>
+<script type="text/javascript" src="{{ pathto('_static/bootstrap.js', 1) }}"></script>
+<script type="text/javascript" src="{{ pathto('_static/doc.js', 1) }}"></script>
+<script type="text/javascript" src="{{ pathto('_static/jquery.noconflict.js', 1) }}"></script>
+{%- endblock %}
 
 {% set classes = [] %}
 {% if pagename == master_doc %}
diff --git a/_extensions/odoo/translator.py b/_extensions/odoo/translator.py
index 8d924c5ef..73572cfed 100644
--- a/_extensions/odoo/translator.py
+++ b/_extensions/odoo/translator.py
@@ -4,7 +4,7 @@ import posixpath
 import re
 
 from docutils import nodes
-from sphinx import addnodes, util
+from sphinx import addnodes, util, builders
 from sphinx.locale import admonitionlabels
 
 try:
@@ -42,6 +42,11 @@ class BootstrapTranslator(nodes.NodeVisitor, object):
     ]
 
     def __init__(self, builder, document):
+        # order of parameter swapped between Sphinx 1.x and 2.x, check if
+        # we're running 1.x and swap back
+        if not isinstance(builder, builders.Builder):
+            builder, document = document, builder
+
         super(BootstrapTranslator, self).__init__(document)
         self.builder = builder
         self.body = []