From 95b7e749560067d8c900f5e9d3b47fbd9a707537 Mon Sep 17 00:00:00 2001
From: Victor Feyens <vfe@odoo.com>
Date: Fri, 25 Sep 2020 12:58:05 +0200
Subject: [PATCH] [POC] to improve: specify other pages to build with banners

---
 _extensions/odoo_ext/__init__.py          |  4 +++-
 _extensions/odoo_ext/breadcrumb_list.html |  1 +
 _extensions/odoo_ext/layout.html          | 16 ++++++++++------
 conf.py                                   |  1 +
 4 files changed, 15 insertions(+), 7 deletions(-)

diff --git a/_extensions/odoo_ext/__init__.py b/_extensions/odoo_ext/__init__.py
index 65d6a05ba..14704663e 100644
--- a/_extensions/odoo_ext/__init__.py
+++ b/_extensions/odoo_ext/__init__.py
@@ -109,7 +109,7 @@ if toctree:
     # than functions on the BuildEnv & al
     @monkey(toctree.TocTree)
     def resolve(old_resolve, tree, docname, *args, **kwargs):
-        if docname == tree.env.config.master_doc:
+        if docname == tree.env.config.master_doc or docname in tree.env.config.banners_doc:
             return resolve_content_toctree(tree.env, docname, *args, **kwargs)
         toc = old_resolve(tree, docname, *args, **kwargs)
         if toc is None:
@@ -124,6 +124,8 @@ def resolve_toctree(old_resolve, self, docname, *args, **kwargs):
     """ If navbar, bootstrapify TOC to yield a navbar
 
     """
+    # VFE NOTE not called since sphinx 1.6
+    # bump the version and remove ?
     navbar = kwargs.pop('navbar', None)
     if docname == self.config.master_doc and not navbar:
         return resolve_content_toctree(self, docname, *args, **kwargs)
diff --git a/_extensions/odoo_ext/breadcrumb_list.html b/_extensions/odoo_ext/breadcrumb_list.html
index 877ba82b2..a129265f4 100644
--- a/_extensions/odoo_ext/breadcrumb_list.html
+++ b/_extensions/odoo_ext/breadcrumb_list.html
@@ -11,6 +11,7 @@
             {% if loop.first %}
                 <li><a href="{{ pathto(master_doc) }}">{{ master_doc_short_name }}</a></li>
             {% else %}
+                <!-- VFE there is no elif ? -->
                 {% if loop.index == 2 %}
                     <li><a href="{{ parent.link|e }}">{{parent.title}}</a></li>
                 {% endif %}
diff --git a/_extensions/odoo_ext/layout.html b/_extensions/odoo_ext/layout.html
index 1c619729a..5f1eccd14 100644
--- a/_extensions/odoo_ext/layout.html
+++ b/_extensions/odoo_ext/layout.html
@@ -1,8 +1,11 @@
 {% extends "basic/layout.html" %}
 {% set html5_doctype = True %}
 
+{# =====  VARIABLES  ====== #}
+{% set banners_doc = 'user/index' %}
+
 {% set classes = [] %}
-{% if pagename == master_doc %}
+{% if pagename == master_doc or pagename == banners_doc %}
   {% set classes = classes + ['index'] %}
 {% endif %}
 
@@ -179,7 +182,7 @@
           </div>
 
           <ul class="navbar-nav navbar-right nav o_sub_nav_actions">
-            {% if pagename != master_doc %}
+            {% if pagename != master_doc and pagename != banners_doc %}
               <li class="divider"></li>
             {% endif%}
 
@@ -225,7 +228,7 @@
     {% set container = 'container' %}
     {% endif %}
       <main class="container {{ ' '.join(classes) }}">
-        {% if pagename != master_doc %}
+        {% if pagename != master_doc and pagename != banners_doc %}
         <div class="o_content row">
           {% if 'has-toc' not in meta and not (pagename in toc) %}
           <aside>
@@ -240,9 +243,10 @@
           </aside>
           {% endif %}
           <article class="doc-body {% if 'has-toc' in meta %}doc-toc{% endif %}{% if pagename in toc%}index-category{% endif %}">
-            {% endif %}
-            {% block body %} {% endblock %}
-          {% if pagename != master_doc %}</article>
+        {% endif %}
+          {% block body %} {% endblock %}
+        {% if pagename != master_doc and pagename != banners_doc %}
+          </article>
         </div>
         {% endif %}
         <div id="mask"></div>
diff --git a/conf.py b/conf.py
index b27559e7b..b3d186ca3 100644
--- a/conf.py
+++ b/conf.py
@@ -295,6 +295,7 @@ def setup(app):
     app.connect('html-page-context', canonicalize)
     app.add_config_value('canonical_root', None, 'env')
     app.add_config_value('canonical_branch', 'master', 'env')
+    app.add_config_value('banners_doc', ['user/index'], 'env')
 
     app.connect('html-page-context', analytics)
     app.add_config_value('google_analytics_key', '', 'env')