[IMP] inventory: stock input + output account fix

closes odoo/documentation#9104

Signed-off-by: Felicia Kuan (feku) <feku@odoo.com>
Co-authored-by: Zachary Straub <zst@odoo.com>
Co-authored-by: Sam Lieber (sali) <36018073+samueljlieber@users.noreply.github.com>

content/applications/finance/accounting/get_started/avg_price_valuation.rst

@@ -25,11 +25,14 @@ to reflect the change in inventory valuation. However, Odoo does **not** automat
 valuation <inventory/avg_price/leaving_inventory>`.
 
 .. note::
-   This document addresses a specific use case for theoretical purposes. Navigate :ref:`here
-   <inventory/inventory_valuation_config>` for instructions on how to set up and use |AVCO| in Odoo.
+   This document addresses a specific use case for theoretical purposes. For instructions on how to
+   set up and use |AVCO|, refer to the :doc:`inventory valuation configuration
+   <../../../inventory_and_mrp/inventory/management/reporting/inventory_valuation_config>`
+   doc.
 
 .. seealso::
-   - :ref:`Using inventory valuation <inventory/reporting/using_inventory_val>`
+   - :doc:`Using inventory valuation
+     <../../../inventory_and_mrp/inventory/management/reporting/using_inventory_valuation>`
    - :ref:`Other inventory valuation methods <inventory/inventory_valuation_config/costing_methods>`
 
 Configuration
@@ -41,7 +44,8 @@ product category page, set :guilabel:`Costing Method` to `Average Cost (AVCO)` a
 :guilabel:`Inventory Valuation` to `Automated`.
 
 .. seealso::
-   :ref:`Inventory valuation configuration <inventory/inventory_valuation_config>`
+   :doc:`Inventory valuation configuration
+   <../../../inventory_and_mrp/inventory/management/reporting/inventory_valuation_config>`
 
 Using average cost valuation
 ============================

content/applications/inventory_and_mrp/inventory/management/reporting/inventory_valuation_config.rst

@@ -2,7 +2,7 @@
 Inventory valuation configuration
 =================================
 
-.. _inventory/inventory_valuation_config:
+.. |external link| replace:: :icon:`fa-external-link` :guilabel:`(external link)`
 
 All of a company's stock on-hand contributes to the valuation of its inventory. That value should
 be reflected in the company's accounting records to accurately show the value of the company and
@@ -11,9 +11,8 @@ all of its assets.
 By default, Odoo uses a periodic inventory valuation (also known as manual inventory valuation).
 This method implies that the accounting team posts journal entries based on the physical inventory
 of the company, and that warehouse employees take the time to count the stock. In Odoo, this method
-is reflected inside each product category, where the :guilabel:`Costing Method` field will be set
-to `Standard Price` by default, and the :guilabel:`Inventory Valuation` field will be set to
-`Manual`.
+is reflected inside each product category, where the :guilabel:`Costing Method` field will be set to
+`Standard Price` by default, and the :guilabel:`Inventory Valuation` field will be set to `Manual`.
 
 .. image:: inventory_valuation_config/inventory-valuation-fields.png
    :align: center
@@ -32,72 +31,85 @@ between locations in a company's inventory.
 .. _inventory/inventory_valuation_config/accounting:
 
 Types of accounting
--------------------
+===================
 
 Accounting entries will depend on the accounting mode: *Continental* or *Anglo-Saxon*.
 
 .. tip::
    Verify the accounting mode by activating the :ref:`developer-mode` and navigating to
-   :menuselection:`Accounting --> Configuration --> Settings`.
+   :menuselection:`Accounting app --> Configuration --> Settings`.
+
+   Then, in the search bar, look for :guilabel:`Anglo-Saxon Accounting`, to see if the feature is
+   enabled. If it is **not** enabled, Continental accounting mode is in use.
+
+   .. image:: inventory_valuation_config/anglo-saxon.png
+      :align: center
+      :alt: Show the Anglo-Saxon accounting mode feature.
 
 In *Anglo-Saxon* accounting, the costs of goods sold (COGS) are reported when products are sold or
 delivered. This means that the cost of a good is only recorded as an expense when a customer is
-invoiced for a product. *Interim Stock Accounts* are used for the input and output accounts, and are
-both *Asset Accounts* in the balance sheet.
+invoiced for a product. So for **manual** valuation method, set the :guilabel:`Expense Account` to
+`Stock Valuation` for the current asset type; for **automatic** valuation method, set the the
+:guilabel:`Expense Account` to an *Expenses* or a *Cost of Revenue* type (e.g. `Cost of Production`,
+`Cost of Goods Sold`, etc.).
 
 In *Continental* accounting, the cost of a good is reported as soon as a product is received into
-stock. Additionally, a single *Expense* account is used for both input and output accounts in
-the balance sheet.
+stock. Because of this, the :guilabel:`Expense Account` can be set to **either** *Expenses* or a
+*Cost of Revenue* type, however, it is more commonly set to an *Expenses* account.
 
-.. _inventory/inventory_valuation_config/costing_methods:
+.. seealso::
+   :ref:`Details about configuring Expense and Stock accounts
+   <inventory/management/config-inventory-valuation>`
 
-Costing methods
----------------
+Configuration
+=============
 
-Below are the three costing methods that can be used in Odoo for inventory valuation.
-
-- **Standard Price**: is the default costing method in Odoo. The cost of the product is manually
-  defined on the product form, and this cost is used to compute the valuation. Even if the purchase
-  price on a purchase order differs, the valuation will still use the cost defined on the product
-  form.
-- **Average Cost (AVCO)**: calculates the valuation of a product based on the average cost of that
-  product, divided by the total number of available stock on-hand. With this costing method,
-  inventory valuation is *dynamic*, and constantly adjusts based on the purchase price of products.
-- **First In First Out (FIFO)**: tracks the costs of incoming and outgoing items in real-time and
-  uses the real price of the products to change the valuation. The oldest purchase price is used as
-  the cost for the next good sold until an entire lot of that product is sold. When the next
-  inventory lot moves up in the queue, an updated product cost is used based on the valuation of
-  that specific lot. This method is arguably the most accurate inventory valuation method for a
-  variety of reasons, however, it's highly sensitive to input data and human error.
-
-.. warning::
-   Changing the costing method greatly impacts inventory valuation. It's highly recommended to
-   consult an accountant first before making any adjustments here.
-
-Configure automated inventory valuation in Odoo
------------------------------------------------
-
-Make changes to inventory valuation options by navigating to :menuselection:`Inventory -->
-Configuration --> Product Categories`, and choose the category/categories where the automated
-valuation method should apply.
+Make changes to inventory valuation options by navigating to :menuselection:`Inventory app -->
+Configuration --> Product Categories`. In the :guilabel:`Inventory Valuation` section, select the
+desired :guilabel:`Costing Method` and :guilabel:`Inventory Valuation` options.
 
 .. note::
    It is possible to use different valuation settings for different product categories.
 
-Under the :guilabel:`Inventory Valuation` heading are two labels: :guilabel:`Costing Method` and
-:guilabel:`Inventory Valuation`. Pick the desired :guilabel:`Costing Method` using the drop-down
-menu (e.g. :guilabel:`Standard`, :guilabel:`Average Cost (AVCO)`, or :guilabel:`First In First Out
-(FIFO)`) and switch the :guilabel:`Inventory Valuation` to :guilabel:`Automated`.
+.. image:: inventory_valuation_config/config-inventory-valuation.png
+   :align: center
+   :alt: Show inventory valuation configuration options.
+
+.. _inventory/inventory_valuation_config/costing_methods:
+
+Costing method
+--------------
+
+From the product category's configuration page, choose the desired :guilabel:`Costing Method`:
+
+- :guilabel:`Standard Price`: the default costing method in Odoo. The cost of the product is
+  manually defined on the product form, and this cost is used to compute the valuation. Even if the
+  purchase price on a purchase order differs, the valuation will still use the cost defined on the
+  product form.
+- :guilabel:`Average Cost (AVCO)`: calculates the valuation of a product based on the average cost
+  of that product, divided by the total number of available stock on-hand. With this costing method,
+  inventory valuation is *dynamic*, and constantly adjusts based on the purchase price of products.
+
+  .. note::
+     When choosing :guilabel:`Average Cost (AVCO)` as the :guilabel:`Costing Method`, changing the
+     numerical value in the :guilabel:`Cost` field for products in the respective product category
+     creates a new record in the *Inventory Valuation* report to adjust the value of the product.
+     The :guilabel:`Cost` amount will then automatically update based on the average purchase price
+     both of inventory on hand and the costs accumulated from validated purchase orders.
+
+- :guilabel:`First In First Out (FIFO)`: tracks the costs of incoming and outgoing items in
+  real-time and uses the real price of the products to change the valuation. The oldest purchase
+  price is used as the cost for the next good sold until an entire lot of that product is sold. When
+  the next inventory lot moves up in the queue, an updated product cost is used based on the
+  valuation of that specific lot. This method is arguably the most accurate inventory valuation
+  method for a variety of reasons, however, it is highly sensitive to input data and human error.
+
+.. warning::
+   Changing the costing method greatly impacts inventory valuation. It is highly recommended to
+   consult an accountant first before making any adjustments here.
 
 .. seealso::
-   :ref:`Using the inventory valuation<inventory/reporting/using_inventory_val>`
-
-.. note::
-   When choosing :guilabel:`Average Cost (AVCO)` as the :guilabel:`Costing Method`, changing the
-   numerical value in the :guilabel:`Cost` field for products in the respective product category
-   creates a new record in the *Inventory Valuation* report to adjust the value of the product. The
-   :guilabel:`Cost` amount will then automatically update based on the average purchase price both
-   of inventory on hand and the costs accumulated from validated purchase orders.
+   :doc:`using_inventory_valuation`
 
 When the :guilabel:`Costing Method` is changed, products already in stock that were using the
 :guilabel:`Standard` costing method **do not** change value; rather, the existing units keep their
@@ -105,12 +117,89 @@ value, and any product moves from then on affect the average cost, and the cost
 change. If the value in the :guilabel:`Cost` field on a product form is changed manually, Odoo will
 generate a corresponding record in the *Inventory Valuation* report.
 
-On the same screen, the :guilabel:`Account Stock Properties` fields will appear, as they are now
-required fields given the change to automated inventory valuation. These accounts are defined as
-follows:
+.. _inventory/management/config-inventory-valuation:
+
+Inventory valuation
+-------------------
+
+Inventory valuation in Odoo can be set to be updated manually or automatically. While *Expense*
+accounts apply to both, the *Stock Input* and *Stock Output* accounts are only used for automated
+valuation.
+
+Refer to the :ref:`Expense <inventory/management/expense-account>` and :ref:`Stock input/output
+<inventory/management/stock-account>` sections for details on configuring each account type.
+
+.. _inventory/management/expense-account:
+
+Expense account
+~~~~~~~~~~~~~~~
+
+To configure the *expense account*, go to the :guilabel:`Account Properties` section of the intended
+product category (:menuselection:`Inventory app --> Configuration --> Product Categories`). Then,
+choose an existing account from the :guilabel:`Expense Account` drop-down menu.
+
+To ensure the chosen account is the correct :guilabel:`Type,` click the |external link| icon to the
+right of the account. Then, set the account type based on the information below.
+
+.. tabs::
+
+   .. group-tab:: Anglo-Saxon
+
+      .. tabs::
+
+         .. group-tab:: Automated
+
+            In Anglo-Saxon accounting for automated inventory valuation, set the :guilabel:`Expense
+            Account` to the `Expenses` account. Then, click the |external link| icon to the right of
+            the account.
+
+            In the pop-up window, choose :guilabel:`Expenses` or :guilabel:`Cost of Revenue` from
+            the :guilabel:`Type` drop-down menu.
+
+            .. image:: inventory_valuation_config/external-link.png
+               :align: center
+               :alt: Show **Expense Account** field, and external link icon.
+
+         .. group-tab:: Manual
+
+            To configure the :guilabel:`Expense Account`, choose :guilabel:`Stock Valuation` from
+            the field's drop-down menu. Verify the account's type by clicking the |external link|
+            icon, and then ensure the :guilabel:`Type` is :guilabel:`Current Assets`.
+
+            .. image:: inventory_valuation_config/manual-anglo-saxon-expense.png
+               :align: center
+               :alt: Show the **Expense Account** field.
+
+   .. group-tab:: Continental
+
+      .. tabs::
+
+         .. group-tab:: Automated
+
+            Set the :guilabel:`Expense Account` to the :guilabel:`Expenses` or :guilabel:`Cost of
+            Revenue` account type.
+
+         .. group-tab:: Manual
+
+            Set the :guilabel:`Expense Account` to the :guilabel:`Expenses` or :guilabel:`Cost of
+            Revenue` account type.
+
+.. _inventory/management/stock-account:
+
+Stock input/output (automated only)
+~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
+
+To configure the :guilabel:`Stock Input Account` and :guilabel:`Stock Output Account`, go to
+:menuselection:`Inventory app --> Configuration --> Product Categories` and select the desired
+product category.
+
+In the :guilabel:`Inventory Valuation` field, select :guilabel:`Automated`. Doing so makes the
+:guilabel:`Account Stock Properties` section appear. These accounts are defined as follows:
 
 - :guilabel:`Stock Valuation Account`: when automated inventory valuation is enabled on a product,
   this account will hold the current value of the products.
+- :guilabel:`Stock Journal`: accounting journal where entries are automatically posted when a
+  product's inventory valuation changes.
 - :guilabel:`Stock Input Account`: counterpart journal items for all incoming stock moves will be
   posted in this account, unless there is a specific valuation account set on the source location.
   This is the default value for all products in a given category, and can also be set directly on
@@ -120,13 +209,52 @@ follows:
   location. This is the default value for all products in a given category, and can also be set
   directly on each product.
 
-Access reporting data generated by inventory valuation
-------------------------------------------------------
+.. tabs::
+
+   .. group-tab:: Anglo-Saxon
+
+      In Anglo-Saxon accounting, the :guilabel:`Stock Input Account` and :guilabel:`Stock Output
+      Account` are set to *different* :guilabel:`Current Assets` accounts. This way, delivering
+      products and invoicing the customer balance the *Stock Output* account, while receiving
+      products and billing vendors balance the *Stock Input* account.
+
+      To modify the account type, go to the click the |external link| icon to the right of the stock
+      input/output account. In the pop-up window, choose :guilabel:`Current Assets` from the
+      :guilabel:`Type` drop-down menu.
+
+      .. figure:: inventory_valuation_config/account-type.png
+         :align: center
+         :alt: Display account setup page, highlighting the **Type** field.
+
+         The *Stock Input* account is set to `Stock Interim (Received)`, a *Current Asset* account
+         type.
+
+   .. group-tab:: Continental
+
+      In Continental accounting, the :guilabel:`Stock Input Account` and :guilabel:`Stock Output
+      Account` are set to **the same** :guilabel:`Current Assets` account. That way, one account can
+      be balanced when items are bought and sold.
+
+      .. example::
+         The stock input and output accounts are both set to `Stock Interim (Received)`, a
+         :guilabel:`Current Assets` account type. They can also be set to the `Stock Interim
+         (Delivered)`, as long as the input and output accounts are assigned to the **same**
+         account.
+
+         .. image:: inventory_valuation_config/continental-stock-account.png
+            :align: center
+            :alt: Show the Stock Input and Output accounts.
+
+Inventory valuation reporting
+=============================
 
 To start, go to :menuselection:`Accounting --> Reporting --> Balance Sheet`. At the top of the
 dashboard, change the :guilabel:`As of` field value to :guilabel:`Today`, and adjust the filtering
-:guilabel:`Options` to :guilabel:`Unfold All` in order to see all of the latest data displayed,
-all at once.
+:guilabel:`Options` to :guilabel:`Unfold All` in order to see all of the latest data displayed, all
+at once.
+
+.. seealso::
+   :doc:`../../../../finance/accounting/get_started/cheat_sheet`
 
 Under the parent :guilabel:`Current Assets` line item, look for the nested :guilabel:`Stock
 Valuation Account` line item, where the total valuation of all of the inventory on hand is

content/applications/inventory_and_mrp/inventory/management/reporting/using_inventory_valuation.rst

@@ -2,8 +2,6 @@
 Using inventory valuation
 =========================
 
-.. _inventory/reporting/using_inventory_val:
-
 *Inventory valuation* is a quintessential accounting procedure that calculates the value of on-hand
 stock. Once determined, the inventory valuation amount is then incorporated into a company's overall
 value.
@@ -12,7 +10,7 @@ In Odoo, this process can be conducted manually— by warehouse employees physic
 products— or automatically through the database.
 
 .. seealso::
-   :ref:`Inventory valuation configuration<inventory/inventory_valuation_config>`
+   :doc:`inventory_valuation_config`
 
 Understand the basics of inventory valuation
 ============================================