NextERP/owl
2
0
Fork 0
mirror of https://github.com/odoo/owl.git synced 2025-10-06 19:59:41 +07:00
Code Issues Packages Projects Releases Wiki Activity

[REF] compiler: minor cleanup

Browse Source 
This commit merges two nested ifs and explicitly joins an array instead
of relying on array -> string coercion
This commit is contained in:
Samuel Degueldre
2023-08-04 08:49:08 +02:00
committed by Lucas Perais - lpe@odoo
parent 9823a4e7dd
commit 28672096a2
22 changed files with 99 additions and 101 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/compiler/code_generator.ts
+4 -6
View File
@@ -761,7 +761,7 @@ export class CodeGenerator {
if (!current) break; if (!current) break;
} }
} }
this.addLine(`let ${block!.children.map((c) => c.varName)};`, codeIdx); this.addLine(`let ${block!.children.map((c) => c.varName).join(", ")};`, codeIdx);
} }
} }
return block!.varName; return block!.varName;
@@ -863,7 +863,7 @@ export class CodeGenerator {
if (!current) break; if (!current) break;
} }
} }
this.addLine(`let ${block!.children.map((c) => c.varName)};`, codeIdx); this.addLine(`let ${block!.children.map((c) => c.varName).join(", ")};`, codeIdx);
} }
// note: this part is duplicated from end of compilemulti: // note: this part is duplicated from end of compilemulti:
@@ -998,8 +998,7 @@ export class CodeGenerator {
} }
} }
if (isNewBlock) { if (isNewBlock) {
if (block!.hasDynamicChildren) { if (block!.hasDynamicChildren && block!.children.length) {
if (block!.children.length) {
const code = this.target.code; const code = this.target.code;
const children = block!.children.slice(); const children = block!.children.slice();
let current = children.shift(); let current = children.shift();
@@ -1010,8 +1009,7 @@ export class CodeGenerator {
if (!current) break; if (!current) break;
} }
} }
this.addLine(`let ${block!.children.map((c) => c.varName)};`, codeIdx); this.addLine(`let ${block!.children.map((c) => c.varName).join(", ")};`, codeIdx);
}
} }
const args = block!.children.map((c) => c.varName).join(", "); const args = block!.children.map((c) => c.varName).join(", ");