NextERP/owl
2
0
Fork 0
mirror of https://github.com/odoo/owl.git synced 2025-10-06 19:59:41 +07:00
Code Issues Packages Projects Releases Wiki Activity

[FIX] app: make sure we maintain the correct prototype chain in env

Browse Source
This commit is contained in:
Géry Debongnie
2022-03-03 15:48:29 +01:00
parent 0457e5d4ed
commit 8d1d0a2244
2 changed files with 5 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/app/app.ts
+3 -2
View File
@@ -52,8 +52,9 @@ export class App<
console.info(DEV_MSG()); console.info(DEV_MSG());
hasBeenLogged = true; hasBeenLogged = true;
} }
const descrs = Object.getOwnPropertyDescriptors(config.env || {}); const env = config.env || {};
this.env = Object.freeze(Object.defineProperties({}, descrs)) as E; const descrs = Object.getOwnPropertyDescriptors(env);
this.env = Object.freeze(Object.create(Object.getPrototypeOf(env), descrs));
this.props = config.props || ({} as P); this.props = config.props || ({} as P);
} }
tests/components/env.test.ts
+2
View File
@@ -49,5 +49,7 @@ describe("env handling", () => {
await new App(Test, { env }).mount(fixture); await new App(Test, { env }).mount(fixture);
expect(child.env).toEqual(env); expect(child.env).toEqual(env);
// we check that the frozen env maintain the same prototype chain
expect(Object.getPrototypeOf(child.env)).toBe(Object.getPrototypeOf(env));
}); });
}); });