From 929178b5e818be71abf14d86dc41097e83662abe Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?G=C3=A9ry=20Debongnie?= <ged@odoo.com>
Date: Wed, 13 Mar 2019 14:29:57 +0100
Subject: [PATCH] add support for t-else directive with t-widget

---
 web/static/src/ts/core/qweb_vdom.ts     |  2 +-
 web/static/tests/core/component.test.ts | 23 +++++++++++++++++++++++
 2 files changed, 24 insertions(+), 1 deletion(-)

diff --git a/web/static/src/ts/core/qweb_vdom.ts b/web/static/src/ts/core/qweb_vdom.ts
index 382e2287..1887aa96 100644
--- a/web/static/src/ts/core/qweb_vdom.ts
+++ b/web/static/src/ts/core/qweb_vdom.ts
@@ -930,7 +930,7 @@ const widgetDirective: Directive = {
 
     ctx.addLine(`extra.promises.push(def${defID});`);
 
-    if (node.getAttribute("t-if")) {
+    if (node.getAttribute("t-if") || node.getAttribute("t-else")) {
       ctx.closeIf();
     }
 
diff --git a/web/static/tests/core/component.test.ts b/web/static/tests/core/component.test.ts
index a5f39cd9..bea01e19 100644
--- a/web/static/tests/core/component.test.ts
+++ b/web/static/tests/core/component.test.ts
@@ -816,6 +816,29 @@ describe("other directives with t-widget", () => {
     await widget.updateState({ flag: true });
     expect(fixture.innerHTML).toBe("<div><span>hey</span></div>");
   });
+
+  test("t-else works with t-widget", async () => {
+    class ParentWidget extends Widget {
+      inlineTemplate = `
+        <div>
+          <div t-if="state.flag">somediv</div>
+          <t t-else="1" t-widget="child"/>
+        </div>`;
+      widgets = { child: Child };
+      state = { flag: true };
+    }
+    class Child extends Widget {
+      inlineTemplate = "<span>hey</span>";
+    }
+
+    const widget = new ParentWidget(env);
+    await widget.mount(fixture);
+
+    expect(normalize(fixture.innerHTML)).toBe("<div><div>somediv</div></div>");
+
+    await widget.updateState({ flag: false });
+    expect(normalize(fixture.innerHTML)).toBe("<div><span>hey</span></div>");
+  });
 });
 
 describe("random stuff/miscellaneous", () => {