[FIX] runtime: log if willStart takes more than 3s

Before this commit, when willStart/willUpdateProps took more than
3s, a console.warn was done. In odoo, when a warning is logged
during a test, the test fails and the build is considered as "in
error".

There's a component that loads several resources (sequentially) in
its onWillStart, which *sometimes* takes more than 3s, making
builds fail non deterministically. Since a recent change (which
adds another call in the problematic onWillStart), the warning gets
logged quite often.

A quick fix is necessary, so we change the warn into a log, which
won't make build fail.

We may consider alternatives in the future though:
 - add a parameter to onWillStart, to disable the timeout, or to
   specify the delay (which is 3s by default)
 - do not warn in test mode
This commit is contained in:
Aaron Bohy
2024-08-14 12:56:32 +02:00
committed by FrancoisGe
parent f8bb86820e
commit 9c2d957525
3 changed files with 24 additions and 24 deletions
+1 -1
View File
@@ -29,7 +29,7 @@ function wrapError(fn: (...args: any[]) => any, hookName: string) {
new Promise((resolve) => setTimeout(() => resolve(TIMEOUT), 3000)),
]).then((res) => {
if (res === TIMEOUT && node.fiber === fiber && node.status <= 2) {
console.warn(timeoutError);
console.log(timeoutError);
}
});
}