From a69f8a39e76a194800edff339a9374d4551f1192 Mon Sep 17 00:00:00 2001 From: Samuel Degueldre Date: Wed, 18 Jan 2023 12:59:24 +0100 Subject: [PATCH] [IMP] runtime: improve useExternalListener typing Previously the type of the target for useExternalListener was HTMLElement or Window, this makes document an invalid target. Here there is no reason to use the EventTarget interface instead, as useExternalListener only uses methods from that interface and should work with any event target. Closes odoo/owl#1323 --- src/runtime/hooks.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/runtime/hooks.ts b/src/runtime/hooks.ts index 9d3b54bd..dc6b5ecc 100644 --- a/src/runtime/hooks.ts +++ b/src/runtime/hooks.ts @@ -117,7 +117,7 @@ export function useEffect(effect: Effect, computeDependencies: () => any[] = () * `useExternalListener(window, 'click', this._doSomething);` * */ export function useExternalListener( - target: HTMLElement | typeof window, + target: EventTarget, eventName: string, handler: EventListener, eventParams?: AddEventListenerOptions