mirror of
https://github.com/odoo/owl.git
synced 2025-10-06 19:59:41 +07:00
[FIX] component: fix wrong behaviour when using t-on on t-component
Before this commit, using t-on on t-component was not correctly implemented by owl: when more than one component shared the same parentelement and have an handler with the same name, the second handler would override the first (using an internal key). With this commit, we simply recreate event handler for each instance of a catcher block. Note that it means that using t-on on components is slightly slower now. Also, this commit fixes an additional issue that was noticed: the catcher block would not update its internal handler properly, so it would not behave properly after being patched. closes #1199
This commit is contained in:
committed by
Sam Degueldre
parent
31b57cbb40
commit
c7bd0ab85c
@@ -319,4 +319,68 @@ describe("t-on", () => {
|
||||
expect(fixture.innerHTML).toBe("<button>button</button>");
|
||||
expect(["hey"]).toBeLogged();
|
||||
});
|
||||
|
||||
test("t-on on components and t-foreach", async () => {
|
||||
class Child extends Component {
|
||||
static template = xml`<div t-esc="props.value"/>`;
|
||||
}
|
||||
|
||||
class Parent extends Component {
|
||||
static template = xml`
|
||||
<t t-foreach="['John', 'Raoul', 'Gérald']" t-as="name" t-key="name">
|
||||
<Child t-on-click="() => this.log(name)" value="name"/>
|
||||
</t>`;
|
||||
static components = { Child };
|
||||
log(name: string) {
|
||||
logStep(name);
|
||||
}
|
||||
}
|
||||
await mount(Parent, fixture);
|
||||
expect(fixture.innerHTML).toBe("<div>John</div><div>Raoul</div><div>Gérald</div>");
|
||||
expect([]).toBeLogged();
|
||||
fixture.querySelectorAll("div")[0].click();
|
||||
await nextTick();
|
||||
expect(["John"]).toBeLogged();
|
||||
|
||||
fixture.querySelectorAll("div")[1].click();
|
||||
await nextTick();
|
||||
expect(["Raoul"]).toBeLogged();
|
||||
|
||||
fixture.querySelectorAll("div")[2].click();
|
||||
await nextTick();
|
||||
expect(["Gérald"]).toBeLogged();
|
||||
});
|
||||
|
||||
test("t-on on components, with a handler update", async () => {
|
||||
class Child extends Component {
|
||||
static template = xml`<div t-esc="props.value"/>`;
|
||||
}
|
||||
|
||||
class Parent extends Component {
|
||||
static template = xml`
|
||||
<t t-set="name" t-value="state.name"/>
|
||||
<Child value="name" t-on-click="() => this.log(name)"
|
||||
/>`;
|
||||
static components = { Child };
|
||||
state = useState({ name: "aaron" });
|
||||
log(name: string) {
|
||||
logStep(name);
|
||||
}
|
||||
}
|
||||
const parent = await mount(Parent, fixture);
|
||||
expect(fixture.innerHTML).toBe("<div>aaron</div>");
|
||||
expect([]).toBeLogged();
|
||||
|
||||
fixture.querySelectorAll("div")[0].click();
|
||||
await nextTick();
|
||||
expect(["aaron"]).toBeLogged();
|
||||
|
||||
parent.state.name = "lucas";
|
||||
await nextTick();
|
||||
expect(fixture.innerHTML).toBe("<div>lucas</div>");
|
||||
|
||||
fixture.querySelectorAll("div")[0].click();
|
||||
await nextTick();
|
||||
expect(["lucas"]).toBeLogged();
|
||||
});
|
||||
});
|
||||
|
||||
Reference in New Issue
Block a user