NextERP/owl
2
0
Fork 0
mirror of https://github.com/odoo/owl.git synced 2025-10-06 19:59:41 +07:00
Code Issues Packages Projects Releases Wiki Activity

handle situation when widget is destroyed before willStart

Browse Source
This commit is contained in:
Géry Debongnie
2019-01-27 21:50:22 +01:00
parent fb6ad6e56b
commit d8c37a2942
2 changed files with 49 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files
web/static/src/ts/core/Widget.ts
+13 -6
View File
@@ -80,9 +80,13 @@ export class Widget<T extends WEnv> {
// Public
//--------------------------------------------------------------------------
async mount(target: HTMLElement): Promise<VNode> {
async mount(target: HTMLElement): Promise<void> {
await this._start();
const vnode = await this.render();
await this.render();
if (!this.el) {
// widget was destroyed before we get here...
return;
}
target.appendChild(this.el!);
if (document.body.contains(target)) {
@@ -93,7 +97,6 @@ export class Widget<T extends WEnv> {
}
});
}
return vnode;
}
destroy() {
@@ -134,18 +137,22 @@ export class Widget<T extends WEnv> {
// Private
//--------------------------------------------------------------------------
async render(): Promise<VNode> {
async render(): Promise<void> {
if (this.__widget__.isDestroyed) {
return;
}
const vnode = await this._render();
this.__widget__.vnode = patch(
this.__widget__.vnode || document.createElement(vnode.sel!),
vnode
);
return this.__widget__.vnode;
}
private async _start(): Promise<void> {
await this.willStart();
this.__widget__.isStarted = true;
if (!this.__widget__.isDestroyed) {
this.__widget__.isStarted = true;
}
}
private async _render(): Promise<VNode> {