NextERP/owl
2
0
Fork 0
mirror of https://github.com/odoo/owl.git synced 2025-10-06 19:59:41 +07:00
Code Issues Packages Projects Releases Wiki Activity

[FIX] component: concurrent rendering issue

Browse Source 
Resolved rendering with cancelled fiber for (not yet) destroyed
component -> Cannot read property 'sel' of null

Closes #421
This commit is contained in:
Aaron Bohy
2019-11-08 09:16:04 +01:00
committed by Géry Debongnie
parent 7e721a96b5
commit e47f604449
7 changed files with 98 additions and 33 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/component/component.ts
+3
View File
@@ -438,6 +438,9 @@ export class Component<T extends Env, Props extends {}> {
}
__owl__.isDestroyed = true;
delete __owl__.vnode;
if (__owl__.currentFiber) {
__owl__.currentFiber.isCancelled = true;
}
}
__callMounted() {
src/component/directive.ts
+1 -1
View File
@@ -455,7 +455,7 @@ QWeb.addDirective({
);
ctx.addLine(`const fiber = w${componentID}.__owl__.currentFiber;`);
ctx.addLine(
`def${defID}.then(function () {if (w${componentID}.__owl__.isDestroyed) {return;} const vnode = fiber.vnode; pvnode.sel = vnode.sel; ${createHook}});`
`def${defID}.then(function () {if (fiber.isCancelled) {return;} const vnode = fiber.vnode; pvnode.sel = vnode.sel; ${createHook}});`
);
if (registerCode) {
ctx.addLine(registerCode);