mirror of
https://github.com/odoo/owl.git
synced 2025-10-06 19:59:41 +07:00
Géry Debongnie
6465665550
The way keys were handled in QWeb was mostly ok, but a little naive. It is fine when we deal with a list of dom nodes, since the reconciliation algorithm need only to be able to differentiate/reconcile nodes in that list, but it is an issue with components, which needs to globally be able to find themselves in their parent's children map. Because of the way this was handled, there were situations were Owl internal virtual dom would crash, since components wrongly assumed that they were already rendered in a different place. To fix this, we generalize the way keys are generated, by concatenating all sub keys coming from each iteration loops. closes #584
47 lines
1.9 KiB
Plaintext
47 lines
1.9 KiB
Plaintext
// Jest Snapshot v1, https://goo.gl/fbAQLP
|
|
|
|
exports[`RouteComponent can render simple cases 1`] = `
|
|
"function anonymous(context, extra
|
|
) {
|
|
// Template name: \\"__template__1\\"
|
|
let utils = this.constructor.utils;
|
|
let QWeb = this.constructor;
|
|
let parent = context;
|
|
let scope = Object.create(context);
|
|
let result;
|
|
let h = this.h;
|
|
if (scope['routeComponent']) {
|
|
{
|
|
let key0 = scope['env'].router.currentRouteName;
|
|
// Component 'routeComponent'
|
|
let k5 = \`__5__\${key0}__\`;
|
|
let w4 = k5 in parent.__owl__.cmap ? parent.__owl__.children[parent.__owl__.cmap[k5]] : false;
|
|
let vn6 = {};
|
|
result = vn6;
|
|
let props4 = Object.assign({}, scope['env'].router.currentParams);
|
|
if (w4 && w4.__owl__.currentFiber && !w4.__owl__.vnode) {
|
|
w4.destroy();
|
|
w4 = false;
|
|
}
|
|
if (w4) {
|
|
w4.__updateProps(props4, extra.fiber, undefined);
|
|
let pvnode = w4.__owl__.pvnode;
|
|
utils.defineProxy(vn6, pvnode);
|
|
} else {
|
|
let componentKey4 = \`routeComponent\`;
|
|
let W4 = context.constructor.components[componentKey4] || QWeb.components[componentKey4]|| scope['routeComponent'];
|
|
if (!W4) {throw new Error('Cannot find the definition of component \\"' + componentKey4 + '\\"')}
|
|
w4 = new W4(parent, props4);
|
|
parent.__owl__.cmap[k5] = w4.__owl__.id;
|
|
let fiber = w4.__prepare(extra.fiber, undefined, () => { const vnode = fiber.vnode; pvnode.sel = vnode.sel; });
|
|
let pvnode = h('dummy', {key: k5, hook: {remove() {},destroy(vn) {w4.destroy();}}});
|
|
utils.defineProxy(vn6, pvnode);
|
|
w4.__owl__.pvnode = pvnode;
|
|
}
|
|
w4.__owl__.parentLastFiberId = extra.fiber.id;
|
|
}
|
|
}
|
|
return result;
|
|
}"
|
|
`;
|