NextERP/runbot
5
0
Fork 0
mirror of https://github.com/odoo/runbot.git synced 2025-03-16 16:05:42 +07:00
Code Issues Actions Packages Projects Releases Wiki Activity
17.0
runbot/runbot_merge/views/runbot_merge_project.xml

94 lines
4.6 KiB
XML
Raw Permalink Normal View History

[IMP] runbot_merge: small reorg of main models file To prep for the addition of the freeze wizard: * move projects out of `pull_requests.py` * then realize half the methods there have no relation to projects and move them to more relevant places in `pull_requests.py` * update corresponding crons (and tests using those crons) as the methods have changed model, and the cron definitions thus need to be updated * split update to labels out of sending feedback comments while at it: labels are not used much during tests so their manipulation can be avoided; and labels are not as urgent as feedback so the crons can be quite a bit slower * move the project view out of `mergebot.xml` as well
2021-11-10 19:13:34 +07:00
<odoo>
<record id="runbot_merge_form_project" model="ir.ui.view">
<field name="name">Project Form</field>
<field name="model">runbot_merge.project</field>
<field name="arch" type="xml">
<form>
[ADD] runbot_merge: ~~tree~~ freeze wizard Provides a less manual interface for creating the freeze: * takes the name of the branch to create * takes any number of PRs which must be part of the freeze * takes PRs representing the HEADs of the new branches Then essentially takes care of the test. Implementation of the actual wizard is not trivial but fairly straightforward and linear, biggest issue is not being able to `project_id.branch_ids[1]` to get the new branch, not sure why but it seems to ignore the ordering, clearing the cache doens't fix it. When creating the branches, add a sleep after each one for secondary rate limiting purposes. Same when deleting branches. Also the forwardbot has been updated to disable the forwardport cron while a freeze is ongoing, this simplifies the freezing process. Note: after recommendation of @aab-odoo, tried using `_applyChanges` in `_checkState` but it simply did not work: the two relational fields got completely frozen and were impossible to update, which is less than ideal. Oh well, hopefully it works well enough like this for now.
2021-11-12 22:04:34 +07:00
<field name="freeze_id" invisible="1"/>
[IMP] runbot_merge: small reorg of main models file To prep for the addition of the freeze wizard: * move projects out of `pull_requests.py` * then realize half the methods there have no relation to projects and move them to more relevant places in `pull_requests.py` * update corresponding crons (and tests using those crons) as the methods have changed model, and the cron definitions thus need to be updated * split update to labels out of sending feedback comments while at it: labels are not used much during tests so their manipulation can be avoided; and labels are not as urgent as feedback so the crons can be quite a bit slower * move the project view out of `mergebot.xml` as well
2021-11-10 19:13:34 +07:00
<header>
[ADD] runbot_merge: ~~tree~~ freeze wizard Provides a less manual interface for creating the freeze: * takes the name of the branch to create * takes any number of PRs which must be part of the freeze * takes PRs representing the HEADs of the new branches Then essentially takes care of the test. Implementation of the actual wizard is not trivial but fairly straightforward and linear, biggest issue is not being able to `project_id.branch_ids[1]` to get the new branch, not sure why but it seems to ignore the ordering, clearing the cache doens't fix it. When creating the branches, add a sleep after each one for secondary rate limiting purposes. Same when deleting branches. Also the forwardbot has been updated to disable the forwardport cron while a freeze is ongoing, this simplifies the freezing process. Note: after recommendation of @aab-odoo, tried using `_applyChanges` in `_checkState` but it simply did not work: the two relational fields got completely frozen and were impossible to update, which is less than ideal. Oh well, hopefully it works well enough like this for now.
2021-11-12 22:04:34 +07:00
<button type="object" name="action_prepare_freeze"
string="Freeze"
[MERGE] bot from 16.0 to 17.0 Broken (can't run odoo at all): - In Odoo 17.0, the `pre_init_hook` takes an env, not a cursor, update `_check_citext`. - Odoo 17.0 rejects `@attrs` and doesn't say where they are or how to update them, fun, hunt down `attrs={'invisible': ...` and try to fix them. - Odoo 17.0 warns on non-multi creates, update them, most were very reasonable, one very wasn't. Test failures: - Odoo 17.0 deprecates `name_get` and doesn't use it as a *source* anymore, replace overrides by overrides to `_compute_display_name`. - Multiple tracking changes: - `_track_set_author` takes a `Partner` not an id. - `_message_compute_author` still requires overriding in order to handle record creation, which in standard doesn't support author overriding. - `mail.tracking.value.field_type` has been removed, the field type now needs to be retrieved from the `field_id`. - Some tracking ordering have changed and require adjusting a few tests. Also added a few flushes before SQL queries which are not (obviously at least) at the start of a cron or controller, no test failure observed but better safe than sorry (probably).
2024-08-12 18:13:03 +07:00
invisible="freeze_id"/>
[ADD] runbot_merge: ~~tree~~ freeze wizard Provides a less manual interface for creating the freeze: * takes the name of the branch to create * takes any number of PRs which must be part of the freeze * takes PRs representing the HEADs of the new branches Then essentially takes care of the test. Implementation of the actual wizard is not trivial but fairly straightforward and linear, biggest issue is not being able to `project_id.branch_ids[1]` to get the new branch, not sure why but it seems to ignore the ordering, clearing the cache doens't fix it. When creating the branches, add a sleep after each one for secondary rate limiting purposes. Same when deleting branches. Also the forwardbot has been updated to disable the forwardport cron while a freeze is ongoing, this simplifies the freezing process. Note: after recommendation of @aab-odoo, tried using `_applyChanges` in `_checkState` but it simply did not work: the two relational fields got completely frozen and were impossible to update, which is less than ideal. Oh well, hopefully it works well enough like this for now.
2021-11-12 22:04:34 +07:00
<button type="object" name="action_prepare_freeze"
string="View Freeze" class="oe_highlight"
[MERGE] bot from 16.0 to 17.0 Broken (can't run odoo at all): - In Odoo 17.0, the `pre_init_hook` takes an env, not a cursor, update `_check_citext`. - Odoo 17.0 rejects `@attrs` and doesn't say where they are or how to update them, fun, hunt down `attrs={'invisible': ...` and try to fix them. - Odoo 17.0 warns on non-multi creates, update them, most were very reasonable, one very wasn't. Test failures: - Odoo 17.0 deprecates `name_get` and doesn't use it as a *source* anymore, replace overrides by overrides to `_compute_display_name`. - Multiple tracking changes: - `_track_set_author` takes a `Partner` not an id. - `_message_compute_author` still requires overriding in order to handle record creation, which in standard doesn't support author overriding. - `mail.tracking.value.field_type` has been removed, the field type now needs to be retrieved from the `field_id`. - Some tracking ordering have changed and require adjusting a few tests. Also added a few flushes before SQL queries which are not (obviously at least) at the start of a cron or controller, no test failure observed but better safe than sorry (probably).
2024-08-12 18:13:03 +07:00
invisible="not freeze_id"/>
[IMP] runbot_merge: small reorg of main models file To prep for the addition of the freeze wizard: * move projects out of `pull_requests.py` * then realize half the methods there have no relation to projects and move them to more relevant places in `pull_requests.py` * update corresponding crons (and tests using those crons) as the methods have changed model, and the cron definitions thus need to be updated * split update to labels out of sending feedback comments while at it: labels are not used much during tests so their manipulation can be avoided; and labels are not as urgent as feedback so the crons can be quite a bit slower * move the project view out of `mergebot.xml` as well
2021-11-10 19:13:34 +07:00
</header>
<sheet>
<div class="oe_title">
<h1><field name="name" placeholder="Name"/></h1>
</div>
<group>
<group>
<field name="github_prefix" string="bot name"/>
</group>
</group>
<group>
<group>
<field name="github_token"/>
[ADD] runbot_merge: github identity for the mergebot Necessary to create commits *as* the mergebot without going through the github API. Copy of the improved version from forwardport. *Not* an override, to avoid unnecessarily triggering one or the other which is confusing and weird.
2023-08-22 13:03:26 +07:00
<field name="github_name" readonly="0"
help="Identity when creating new commits, defaults to github name, falls back to login."/>
<field name="github_email" readonly="0"
help="Identity when creating new commits, defaults to public email, falls back to primary email."/>
[MERGE] bot from 16.0 to 17.0 Broken (can't run odoo at all): - In Odoo 17.0, the `pre_init_hook` takes an env, not a cursor, update `_check_citext`. - Odoo 17.0 rejects `@attrs` and doesn't say where they are or how to update them, fun, hunt down `attrs={'invisible': ...` and try to fix them. - Odoo 17.0 warns on non-multi creates, update them, most were very reasonable, one very wasn't. Test failures: - Odoo 17.0 deprecates `name_get` and doesn't use it as a *source* anymore, replace overrides by overrides to `_compute_display_name`. - Multiple tracking changes: - `_track_set_author` takes a `Partner` not an id. - `_message_compute_author` still requires overriding in order to handle record creation, which in standard doesn't support author overriding. - `mail.tracking.value.field_type` has been removed, the field type now needs to be retrieved from the `field_id`. - Some tracking ordering have changed and require adjusting a few tests. Also added a few flushes before SQL queries which are not (obviously at least) at the start of a cron or controller, no test failure observed but better safe than sorry (probably).
2024-08-12 18:13:03 +07:00
<span invisible="not (staging_statuses and staging_rpc)" class="alert alert-warning" role="alert">
[ADD] runbot_merge: support for non-webhook staging validation Add support for the ability to validate *stagings* over RPC rather than via webhook. This may later be expanded to PRs as well. The core motivation for this is to avoid bouncing through github which sometimes drops the ball on statuses, and it's frustrating to have a staging time out because GH fucked up. Implemented via RPC, requiring both the staging itself (by id) and the head commit being affected, as that is necessary to know what CIs are required for that head and correctly report cross branch on the various PRs. Fix #881 (kinda)
2024-06-03 17:59:24 +07:00
Avoid overlaps between GH and RPC as the older
GH statuses may overwrite more recent RPC statuses.
</span>
<field name="staging_statuses" string="Validate via GH statuses"/>
<field name="staging_rpc" string="Validate via direct RPC"/>
[IMP] runbot_merge: small reorg of main models file To prep for the addition of the freeze wizard: * move projects out of `pull_requests.py` * then realize half the methods there have no relation to projects and move them to more relevant places in `pull_requests.py` * update corresponding crons (and tests using those crons) as the methods have changed model, and the cron definitions thus need to be updated * split update to labels out of sending feedback comments while at it: labels are not used much during tests so their manipulation can be avoided; and labels are not as urgent as feedback so the crons can be quite a bit slower * move the project view out of `mergebot.xml` as well
2021-11-10 19:13:34 +07:00
</group>
<group>
[ADD] runbot_merge: option to disable staging without cron Because the mergebot crons are on such a tight scheduling, and just them finding out they have nothing to do can take a while, disabling them can be a chore. Disabling staging via the project is much less likely to cause issues as the projects don't normally (or ever?) get exclusively locked, so they can generally be written to at any moment. Furthermore, if we ever get in a situation where we have multiple active projects (not really the case currently, we have multiple projects but only one is really active) it's less disruptive to disable stagings on a single specific project. Fixes #860
2023-11-29 19:58:40 +07:00
<field name="staging_enabled" widget="boolean_toggle"/>
[ADD] runbot_merge: support staging ready PRs over splits Not sure it's going to be useful but it's hard to know if we can't test it. The intent is mostly the ability to prioritize throughput (or attempt to) during high-load events, if we can favour staging N new batches over a split's N/2 we might be able to merge more crap. But maybe not, we'll see, either way now it's here and seems to more or less work. Fixes #798
2023-11-30 18:27:09 +07:00
<field name="staging_priority"/>
[IMP] runbot_merge: make uniquifier commit optional Prepares the possibility of either more direct communication with the CI platform(s) or just assuming CI has gotten reliable enough and colleagues intelligent enough that this is not an issue anymore because they've stopped pushing empty branches (which we know is not the case). Fixes #806
2023-10-06 20:19:36 +07:00
<field name="uniquifier"/>
[IMP] runbot_merge: small reorg of main models file To prep for the addition of the freeze wizard: * move projects out of `pull_requests.py` * then realize half the methods there have no relation to projects and move them to more relevant places in `pull_requests.py` * update corresponding crons (and tests using those crons) as the methods have changed model, and the cron definitions thus need to be updated * split update to labels out of sending feedback comments while at it: labels are not used much during tests so their manipulation can be avoided; and labels are not as urgent as feedback so the crons can be quite a bit slower * move the project view out of `mergebot.xml` as well
2021-11-10 19:13:34 +07:00
<field name="ci_timeout"/>
<field name="batch_limit"/>
</group>
</group>
[ADD] runbot_merge: ~~tree~~ freeze wizard Provides a less manual interface for creating the freeze: * takes the name of the branch to create * takes any number of PRs which must be part of the freeze * takes PRs representing the HEADs of the new branches Then essentially takes care of the test. Implementation of the actual wizard is not trivial but fairly straightforward and linear, biggest issue is not being able to `project_id.branch_ids[1]` to get the new branch, not sure why but it seems to ignore the ordering, clearing the cache doens't fix it. When creating the branches, add a sleep after each one for secondary rate limiting purposes. Same when deleting branches. Also the forwardbot has been updated to disable the forwardport cron while a freeze is ongoing, this simplifies the freezing process. Note: after recommendation of @aab-odoo, tried using `_applyChanges` in `_checkState` but it simply did not work: the two relational fields got completely frozen and were impossible to update, which is less than ideal. Oh well, hopefully it works well enough like this for now.
2021-11-12 22:04:34 +07:00
<group class="oe_edit_only">
<group colspan="4">
<label for="freeze_reminder">
Reminder to show after freeze
</label>
<field colspan="4" name="freeze_reminder" nolabel="1"/>
</group>
</group>
[IMP] runbot_merge: small reorg of main models file To prep for the addition of the freeze wizard: * move projects out of `pull_requests.py` * then realize half the methods there have no relation to projects and move them to more relevant places in `pull_requests.py` * update corresponding crons (and tests using those crons) as the methods have changed model, and the cron definitions thus need to be updated * split update to labels out of sending feedback comments while at it: labels are not used much during tests so their manipulation can be avoided; and labels are not as urgent as feedback so the crons can be quite a bit slower * move the project view out of `mergebot.xml` as well
2021-11-10 19:13:34 +07:00
<separator string="Repositories"/>
<field name="repo_ids">
<tree>
<field name="sequence" widget="handle"/>
[FIX] runbot_merge: dumbshit 16.0 view validation complaints
2024-08-09 15:09:20 +07:00
<button type="object" name="get_formview_action" icon="fa-external-link" title="open repo"/>
[IMP] runbot_merge: small reorg of main models file To prep for the addition of the freeze wizard: * move projects out of `pull_requests.py` * then realize half the methods there have no relation to projects and move them to more relevant places in `pull_requests.py` * update corresponding crons (and tests using those crons) as the methods have changed model, and the cron definitions thus need to be updated * split update to labels out of sending feedback comments while at it: labels are not used much during tests so their manipulation can be avoided; and labels are not as urgent as feedback so the crons can be quite a bit slower * move the project view out of `mergebot.xml` as well
2021-11-10 19:13:34 +07:00
<field name="name"/>
<field name="branch_filter"/>
<field name="status_ids" widget="many2many_tags"/>
</tree>
</field>
<separator string="Branches"/>
<field name="branch_ids">
<tree editable="bottom" decoration-muted="not active">
<field name="sequence" widget="handle" />
[FIX] runbot_merge: dumbshit 16.0 view validation complaints
2024-08-09 15:09:20 +07:00
<button type="object" name="get_formview_action" icon="fa-external-link" title="open branch"/>
[IMP] runbot_merge: small reorg of main models file To prep for the addition of the freeze wizard: * move projects out of `pull_requests.py` * then realize half the methods there have no relation to projects and move them to more relevant places in `pull_requests.py` * update corresponding crons (and tests using those crons) as the methods have changed model, and the cron definitions thus need to be updated * split update to labels out of sending feedback comments while at it: labels are not used much during tests so their manipulation can be avoided; and labels are not as urgent as feedback so the crons can be quite a bit slower * move the project view out of `mergebot.xml` as well
2021-11-10 19:13:34 +07:00
<field name="name"/>
[FIX] runbot_merge: disable autosave on boolean toggles That's a bit of a weird one: apparently the boolean_toggle widget has an `autosave` option which should be `true` by default, effecting the row as soon as the toggle is toggled[^1]. But in 15.0 and 18.0 it seems to have no effect, the `boolean_toggle` always just stores the change in the parent form and that gets "committed on save. In 16.0 and 17.0 however it does have an effect, toggling the control will immediately save its value *without going through the parent form*, resulting in the override to `Project.write` managing new/existing branches to not be called, thus not calling `Project_followup_prs`, and ultimately not creating the followup forward ports. After contacting AAB to get more info (and grepping a bit): - autosave was added (enabled by default) in 16.0 after the owl rewrite (odoo/odoo@28e6b7eb83e4309c4e70974d947194bdca240865) - toggle was added in 17.0 (odoo/odoo@a449b05221d454afc7254be0fc8b84d7ff7ffc2f) - feature was removed in 18.0 (odoo/odoo@6bd2c1fdfb5722b1f2d4fc2684f20ed067b93b7d) Which explains why the issue occurs in 16.0 and 17.0, and not in 15.0 or 18.0. Fixes #1051 [^1]: but apparently not going through the parent form...
2025-02-12 18:48:44 +07:00
<field name="active" widget="boolean_toggle" options="{'autosave': false}"/>
<field name="staging_enabled" widget="boolean_toggle" options="{'autosave': false}"/>
[IMP] runbot_merge: small reorg of main models file To prep for the addition of the freeze wizard: * move projects out of `pull_requests.py` * then realize half the methods there have no relation to projects and move them to more relevant places in `pull_requests.py` * update corresponding crons (and tests using those crons) as the methods have changed model, and the cron definitions thus need to be updated * split update to labels out of sending feedback comments while at it: labels are not used much during tests so their manipulation can be avoided; and labels are not as urgent as feedback so the crons can be quite a bit slower * move the project view out of `mergebot.xml` as well
2021-11-10 19:13:34 +07:00
</tree>
</field>
</sheet>
</form>
</field>
</record>
[ADD] runbot_merge: ~~tree~~ freeze wizard Provides a less manual interface for creating the freeze: * takes the name of the branch to create * takes any number of PRs which must be part of the freeze * takes PRs representing the HEADs of the new branches Then essentially takes care of the test. Implementation of the actual wizard is not trivial but fairly straightforward and linear, biggest issue is not being able to `project_id.branch_ids[1]` to get the new branch, not sure why but it seems to ignore the ordering, clearing the cache doens't fix it. When creating the branches, add a sleep after each one for secondary rate limiting purposes. Same when deleting branches. Also the forwardbot has been updated to disable the forwardport cron while a freeze is ongoing, this simplifies the freezing process. Note: after recommendation of @aab-odoo, tried using `_applyChanges` in `_checkState` but it simply did not work: the two relational fields got completely frozen and were impossible to update, which is less than ideal. Oh well, hopefully it works well enough like this for now.
2021-11-12 22:04:34 +07:00
<record id="project_freeze_reminder" model="ir.ui.view">
<field name="name">Project Form</field>
<field name="model">runbot_merge.project</field>
<field name="arch" type="xml">
<form>
<sheet>
<field name="freeze_reminder" nolabel="1" readonly="1"/>
</sheet>
</form>
</field>
</record>
[IMP] runbot_merge: small reorg of main models file To prep for the addition of the freeze wizard: * move projects out of `pull_requests.py` * then realize half the methods there have no relation to projects and move them to more relevant places in `pull_requests.py` * update corresponding crons (and tests using those crons) as the methods have changed model, and the cron definitions thus need to be updated * split update to labels out of sending feedback comments while at it: labels are not used much during tests so their manipulation can be avoided; and labels are not as urgent as feedback so the crons can be quite a bit slower * move the project view out of `mergebot.xml` as well
2021-11-10 19:13:34 +07:00
</odoo>
Reference in New Issue Copy Permalink