NextERP/runbot
5
0
Fork 0
mirror of https://github.com/odoo/runbot.git synced 2025-03-27 13:25:47 +07:00
Code Issues Actions Packages Projects Releases Wiki Activity

[FIX] runbot: return closest branch when PR head name are equals (#11)

Browse Source 
When searching for the closest branch name in a target repo, if the PR
head names are equals, a branch method is called on a dictionary, causing
a traceback.

With this commit, the method is called on a branch object instance.

closes #11
This commit is contained in:
Christophe Monniez 2018-04-19 16:16:24 +02:00 committed by GitHub
parent fa6a0944f4
commit 0cb07e73db
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
runbot/models/build.py
View File

@ -158,10 +158,10 @@ class runbot_build(models.Model):
] ]
pulls = Branch.search_read(domain, fields, order='id DESC') pulls = Branch.search_read(domain, fields, order='id DESC')
pulls = sorted(pulls, key=sort_by_repo) pulls = sorted(pulls, key=sort_by_repo)
for pull in pulls: for pull in Branch.browse([pu['id'] for pu in pulls]):
pi = pull._get_pull_info() pi = pull._get_pull_info()
if pi.get('state') == 'open': if pi.get('state') == 'open':
return result_for(pull) return (pull.repo_id.id, pull.name, 'exact')
# 3. Match a branch which is the dashed-prefix of current branch name # 3. Match a branch which is the dashed-prefix of current branch name
branches = Branch.search_read( branches = Branch.search_read(