From 12febd1920838c359d7b0e0584ffa5b3626f9e22 Mon Sep 17 00:00:00 2001 From: Xavier-Do Date: Wed, 4 Dec 2019 12:13:18 +0100 Subject: [PATCH] [FIX] runbot: reintroduce try exept in get_params This commit was initially there for tests, when no repo exist, but get_param will also crash if commit does not exist, wich may be a problem on user rebuild. --- runbot/models/build.py | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/runbot/models/build.py b/runbot/models/build.py index e5e5f23d..ea5b457b 100644 --- a/runbot/models/build.py +++ b/runbot/models/build.py @@ -380,8 +380,10 @@ class runbot_build(models.Model): build.build_age = int(time.time() - dt2time(build.build_start)) def _get_params(self): - message = False - message = self.repo_id._git(['show', '-s', self.name]) + try: + message = self.repo_id._git(['show', '-s', self.name]) + except CalledProcessError: + message = '' params = defaultdict(lambda: defaultdict(str)) if message: regex = re.compile(r'^[\t ]*Runbot-dependency: ([A-Za-z0-9\-_]+/[A-Za-z0-9\-_]+):([0-9A-Fa-f\-]*) *(#.*)?$', re.M) # dep:repo:hash #comment