From 15680a3e187018df86688ed62444c1e1854ebe92 Mon Sep 17 00:00:00 2001
From: Christophe Monniez <moc@odoo.com>
Date: Wed, 13 Sep 2023 15:43:11 +0200
Subject: [PATCH] [IMP] runbot: add warning ribbon when an error is a link

It happens that a user edits or annotates a build error form without
noticing that the error is linked to another one. In that case, the
modification or the note is probably useless. So a warning ribbon should
grab his attention.

While at it, we change the warning ribbon when an error has a test-tag
to not be confused with the link ribbon and also because removing a
test-tag can lead to a real danger (for the mergebot stagings).
---
 runbot/views/build_error_views.xml | 9 +++++----
 1 file changed, 5 insertions(+), 4 deletions(-)

diff --git a/runbot/views/build_error_views.xml b/runbot/views/build_error_views.xml
index 3226886d..49d8258a 100644
--- a/runbot/views/build_error_views.xml
+++ b/runbot/views/build_error_views.xml
@@ -6,7 +6,8 @@
         <field name="arch" type="xml">
           <form>
             <sheet>
-              <widget name="web_ribbon" title="Test-tags" bg_color="bg-warning" attrs="{'invisible': [('test_tags', '=', False)]}"/>
+              <widget name="web_ribbon" title="Test-tags" bg_color="bg-danger" attrs="{'invisible': [('test_tags', '=', False)]}"/>
+              <widget name="web_ribbon" title="Linked to another error" bg_color="bg-warning" attrs="{'invisible': [('parent_id', '=', False)]}"/>
               <header>
               </header>
                 <group name="build_error_group" string="Base info" col="2">
@@ -22,8 +23,8 @@
                     <field name="fixing_pr_id"/>
                     <field name="fixing_pr_url" widget="url"/>
                     <field name="active"/>
-                    <field name="test_tags" readonly="1" groups="!runbot.group_runbot_admin"/>
-                    <field name="test_tags" groups="runbot.group_runbot_admin" attrs="{'readonly': [('parent_id','!=', False), ('test_tags','=', False)]}"/>
+                    <field name="test_tags" decoration-danger="True" readonly="1" groups="!runbot.group_runbot_admin"/>
+                    <field name="test_tags" decoration-danger="True" groups="runbot.group_runbot_admin" attrs="{'readonly': [('parent_id','!=', False), ('test_tags','=', False)]}"/>
                   </group>
                   <group>
                     <field name="version_ids" widget="many2many_tags"/>
@@ -38,7 +39,7 @@
                     <field name="first_seen_build_id" widget="frontend_url"/>
                   </group>
                   <group>
-                    <field name="parent_id"/>
+                    <field name="parent_id" decoration-warning="parent_id != False"/>
                     <field name="last_seen_date"/>
                     <field name="last_seen_build_id" widget="frontend_url"/>
                   </group>