From 1cf33f9635da2032db5889239cdadf1b047c5198 Mon Sep 17 00:00:00 2001
From: Xavier Morel <xmo@odoo.com>
Date: Mon, 25 Oct 2021 09:07:38 +0200
Subject: [PATCH] [IMP] runbot_merge: add misconfiguration warning to partner
 view

Following #531 reviews from reviewers without an email set are
rejected.

For delegates this isn't very helpful, however for specifically
configured reviewers we can warn the configurer that they need to set
an email for things to work out.
---
 runbot_merge/views/res_partner.xml | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/runbot_merge/views/res_partner.xml b/runbot_merge/views/res_partner.xml
index 8a7e6429..9bd97f1b 100644
--- a/runbot_merge/views/res_partner.xml
+++ b/runbot_merge/views/res_partner.xml
@@ -25,6 +25,11 @@
                             attrs="{'invisible': ['|', ('email', '!=', False), ('github_login', '=', False)]}"
                     />
                 </header>
+                <div class="alert alert-warning" role="alert"
+                     attrs="{'invisible': ['|', ('email', '!=', False), ('review_rights', '=', [])]}">
+                  Reviewers must have an email address set! Without an email
+                  configured, reviews will be ignored.
+                </div>
             </xpath>
             <xpath expr="//notebook" position="inside">
                 <page string="Mergebot" groups="runbot_merge.group_admin">