From 1fa7e4c0c7bd0c35277c98c25cd4c7d370a6eed4 Mon Sep 17 00:00:00 2001 From: William Braeckman Date: Mon, 23 Dec 2024 10:34:38 +0100 Subject: [PATCH] [IMP] runbot: improve pull request widget --- runbot/static/src/js/fields/fields.js | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/runbot/static/src/js/fields/fields.js b/runbot/static/src/js/fields/fields.js index 8b833bf3..302f6a5e 100644 --- a/runbot/static/src/js/fields/fields.js +++ b/runbot/static/src/js/fields/fields.js @@ -138,15 +138,19 @@ registry.category("fields").add("char_frontend_url", { // Pull Request URL Widget +const pullRequestRegex = /\/([a-zA-Z-_]+\/[a-zA-Z-_]+)\/pull\/(\d+)/; class PullRequestUrlField extends UrlField { static template = xml` - + `; static components = { UrlField } - setup() { - if (!this.props.readonly) { - throw new Error("This widget works only on readonly fields"); + get fieldProps() { + const props = {...this.props}; + const parts = pullRequestRegex.exec(this.props.record.data[props.name]) + if (parts) { + props.text = `${parts[1]}#${parts[2]}`; } + return props } }