From 2604d962e92170206a6f965a51479c2f2f25c9fb Mon Sep 17 00:00:00 2001
From: Xavier-Do <xdo@odoo.com>
Date: Thu, 19 Aug 2021 16:01:30 +0200
Subject: [PATCH] [FIX] runbot_build_stats

Since the order was changed, the first values are actually the older ones.
This commit inverse newer_build_stats and older_build_stats
values in order to always have the new keys. Before this commit the new
keys where not displayed. A future improvement may be to combine keys
from all builds.

This commit also proposes to give a 0 value if the key did not exist in
the older build. This means that new keys will appear with a big
difference. This is maybe not a good idea and needs some testing. A
better solution would be to search for the first apparition.
---
 runbot/static/src/js/stats.js | 22 ++++++++++++++--------
 1 file changed, 14 insertions(+), 8 deletions(-)

diff --git a/runbot/static/src/js/stats.js b/runbot/static/src/js/stats.js
index 383f6601..e92bd987 100644
--- a/runbot/static/src/js/stats.js
+++ b/runbot/static/src/js/stats.js
@@ -81,12 +81,12 @@ function process_chart_data(){
       return
     }
     var builds = Object.keys(config.result);
-    var newer_build_stats = config.result[builds[0]];
-    var older_build_stats = config.result[builds.slice(-1)[0]];
+    var newer_build_stats = config.result[builds.slice(-1)[0]];
+    var older_build_stats = config.result[builds[0]];
 
     var mode = document.getElementById('mode_selector').value;
     
-    var keys = Object.keys(newer_build_stats);
+    var keys = Object.keys(newer_build_stats) ;
 
     var sort_values = {}
     for (key of keys) {
@@ -107,9 +107,13 @@ function process_chart_data(){
           previous = value
         }
       }
-      else if (older_build_stats[key] !== undefined) {
+      else {
         if (mode == "difference") {
-          sort_value = Math.abs(newer_build_stats[key] - older_build_stats[key])
+          var previous_value = 0;
+          if (older_build_stats[key] !== undefined) {
+            previous_value = older_build_stats[key]
+          }
+          sort_value = Math.abs(newer_build_stats[key] - previous_value)
         }
       }
       sort_values[key] = sort_value
@@ -127,9 +131,11 @@ function process_chart_data(){
           return NaN;
       if (mode == 'normal' || mode == 'alpha')
           return build_stats[key]
-      if (older_build_stats[key] === undefined)
-          return NaN;
-      return  build_stats[key] - older_build_stats[key]
+      var previous_value = 0;
+      if (older_build_stats[key] !== undefined) {
+            previous_value = older_build_stats[key]
+      }
+      return  build_stats[key] - previous_value
     }
 
     config.data = {