From 2aed7e1a48be9b798070d728c0440c9f435258e5 Mon Sep 17 00:00:00 2001
From: Xavier-Do <xdo@odoo.com>
Date: Thu, 25 Jul 2019 13:12:54 +0200
Subject: [PATCH] [IMP] runbot: imp build result display

If children are killed, they will all look the same in the parent view
making difficult to find the failed one in staging branches.

This commit displays result rather than status in priority if build
is in failure.
---
 runbot/templates/build.xml | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/runbot/templates/build.xml b/runbot/templates/build.xml
index 2fcd2f3f..52252895 100644
--- a/runbot/templates/build.xml
+++ b/runbot/templates/build.xml
@@ -191,12 +191,12 @@
                         </nav>
                         <t t-set="rowclass">info</t>
                         <t t-if="build.global_state in ['running','done']">
-                          <t t-if="build.global_result == 'ko'"><t t-set="rowclass">danger</t></t>
-                          <t t-if="build.global_result == 'warn'"><t t-set="rowclass">warning</t></t>
                           <t t-if="build.global_result == 'ok'"><t t-set="rowclass">success</t></t>
                           <t t-if="build.global_result == 'skipped'"><t t-set="rowclass">default</t></t>
                           <t t-if="build.global_result in ['killed', 'manually_killed']"><t t-set="rowclass">killed</t></t>
                         </t>
+                        <t t-if="build.global_result == 'ko'"><t t-set="rowclass">danger</t></t>
+                        <t t-if="build.global_result == 'warn'"><t t-set="rowclass">warning</t></t>
                         <table class="table table-condensed tabel-bordered">
                           <tr>
                             <td t-attf-class="{{rowclass}}">
@@ -220,12 +220,12 @@
                                 <t t-foreach="build.children_ids" t-as="child">
                                   <t t-set="rowclass">info</t>
                                   <t t-if="child.global_state in ['running','done']">
-                                    <t t-if="child.global_result == 'ko'"><t t-set="rowclass">danger</t></t>
-                                    <t t-if="child.global_result == 'warn'"><t t-set="rowclass">warning</t></t>
                                     <t t-if="child.global_result == 'ok'"><t t-set="rowclass">success</t></t>
                                     <t t-if="child.global_result == 'skipped'"><t t-set="rowclass">default</t></t>
                                     <t t-if="child.global_result in ['killed', 'manually_killed']"><t t-set="rowclass">killed</t></t>
                                   </t>
+                                  <t t-if="child.global_result == 'ko'"><t t-set="rowclass">danger</t></t>
+                                  <t t-if="child.global_result == 'warn'"><t t-set="rowclass">warning</t></t>
                                   <tr><td t-attf-class="{{rowclass}}">
                                     <a t-attf-href="/runbot/build/{{child.id}}" >Build <t t-esc="child.id"/></a> 
                                     with config <a t-attf-href="/web#id={{child.config_id.id}}&amp;view_type=form&amp;model=runbot.build.config"><t t-esc="child.config_id.name"/></a>