From 360d0e17ca117624b964b0ef4bb234b945d90685 Mon Sep 17 00:00:00 2001 From: Xavier Morel Date: Mon, 4 Mar 2019 13:17:10 +0100 Subject: [PATCH] [IMP] runbot_merge: don't quote signoff Proper RFC5322 makes for much noisier messages, and seems completely unnecessary as examples of sign-off on the internet don't quote spaces / names. closes #102 --- runbot_merge/models/res_partner.py | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/runbot_merge/models/res_partner.py b/runbot_merge/models/res_partner.py index 0860a8fa..e170e80c 100644 --- a/runbot_merge/models/res_partner.py +++ b/runbot_merge/models/res_partner.py @@ -1,4 +1,4 @@ -from email.utils import parseaddr, formataddr +from email.utils import parseaddr from odoo import fields, models, tools, api class Partner(models.Model): @@ -16,9 +16,8 @@ class Partner(models.Model): self._cr, 'runbot_merge_unique_gh_login', self._table, ['github_login']) return res - @api.multi + @api.depends('name', 'email', 'github_login') def _rfc5322_formatted(self): - # format partner's email according to RFC5322 section 3.4 for partner in self: if partner.email: email = parseaddr(partner.email)[1] @@ -26,4 +25,4 @@ class Partner(models.Model): email = '%s@users.noreply.github.com' % partner.github_login else: email = '' - partner.formatted_email = formataddr((partner.name, email)) + partner.formatted_email = '%s <%s>' % (partner.name, email)