From 401e2f4f51a9d44c1a185eae0c985eb4ab9ac0c9 Mon Sep 17 00:00:00 2001
From: William Braeckman <wbr@odoo.com>
Date: Fri, 25 Oct 2024 12:54:11 +0200
Subject: [PATCH] [REF] runbot: stop using link type ir.logging

Stop using the special $$icon$$ syntax when logging the download url for
the database dump.
---
 runbot/models/build_config.py | 12 +++++++-----
 runbot/templates/build.xml    |  1 +
 2 files changed, 8 insertions(+), 5 deletions(-)

diff --git a/runbot/models/build_config.py b/runbot/models/build_config.py
index ee189c0c..21b87b20 100644
--- a/runbot/models/build_config.py
+++ b/runbot/models/build_config.py
@@ -925,13 +925,15 @@ class ConfigStep(models.Model):
             build._logger('Step %s finished in %s' % (self.name, s2human(build.job_time)))
             return
 
-        kwargs = dict(message='Step %s finished in %s' % (self.name, s2human(build.job_time)))
+        message = 'Step %s finished in %s'
+        args = [self.name, s2human(build.job_time)]
+        log_type = 'runbot'
         if self.job_type == 'install_odoo':
-            kwargs['message'] += ' $$fa-download$$'
             db_suffix = build.params_id.config_data.get('db_name') or (build.params_id.dump_db.db_suffix if not self.create_db else False) or self.db_name
-            kwargs['path'] = '%s%s-%s.zip' % (build._http_log_url(), build.dest, db_suffix)
-            kwargs['log_type'] = 'link'
-        build._log('', **kwargs)
+            message += ' [@icon-download](%s%s-%s.zip)'
+            args += [build._http_log_url(), build.dest, db_suffix]
+            log_type = 'markdown'
+        build._log('', message, *args, log_type=log_type)
 
         if self.coverage:
             xml_url = '%scoverage.xml' % build._http_log_url()
diff --git a/runbot/templates/build.xml b/runbot/templates/build.xml
index edec42ca..4628c9bf 100644
--- a/runbot/templates/build.xml
+++ b/runbot/templates/build.xml
@@ -286,6 +286,7 @@
                         <a t-att-href="href" t-attf-title="Func: {{l.func}}"><t t-esc="l.name"/>:<t t-esc="l.line"/></a>
                       </t>
                     </t>
+                    <!-- DEPRECATED: Will be removed once no ir.logging is concerned. -->
                     <span class="log_message" t-if="l.type == 'link' and len(l.message.split('$$')) == 3">
                       <t t-set="message" t-value="l.message.split('$$')"/>
                       <t t-if="message[1].startswith('fa-')">