From 47428a4580354ce358f69bb4b3f0cd637a500ff1 Mon Sep 17 00:00:00 2001 From: Xavier Morel Date: Tue, 3 Apr 2018 15:02:59 +0200 Subject: [PATCH] [IMP] runbot_merge: only label PR if not created merged/closed Would generate a ton of GH API churn when synchronising. --- runbot_merge/models/pull_requests.py | 13 +++++++------ 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/runbot_merge/models/pull_requests.py b/runbot_merge/models/pull_requests.py index a05251d4..808f987a 100644 --- a/runbot_merge/models/pull_requests.py +++ b/runbot_merge/models/pull_requests.py @@ -559,12 +559,13 @@ class PullRequests(models.Model): @api.model def create(self, vals): pr = super().create(vals) - self.env['runbot_merge.pull_requests.tagging'].create({ - 'pull_request': pr.number, - 'repository': pr.repository.id, - 'state_from': False, - 'state_to': pr._tagstate, - }) + if pr.state not in ('closed', 'merged'): + self.env['runbot_merge.pull_requests.tagging'].create({ + 'pull_request': pr.number, + 'repository': pr.repository.id, + 'state_from': False, + 'state_to': pr._tagstate, + }) return pr @api.multi