From 4a521e12512604a1edae4ecdf5f044940c82af24 Mon Sep 17 00:00:00 2001
From: Xavier Morel <xmo@odoo.com>
Date: Thu, 20 Jun 2024 14:21:40 +0200
Subject: [PATCH] [IMP] runbot_merge: hide backend links from group_user

The backend links in the PR dashboard were gated behind the
`group_user` (internal user) group, however turns out while internal
users have read access to PRs they don't have access to ancillary
objects (e.g. batches, stagings, the link between stagings and
batches), and I think the only way to fix the issue would be to move
it to an optional inheritance (inheritance + group), because `groups`
on view nodes only hides the content without removing it.

I believe in more recent Odoo versions this actually works correctly,
so that might actually be more of an incentive to upgrade...
---
 runbot_merge/views/templates.xml | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/runbot_merge/views/templates.xml b/runbot_merge/views/templates.xml
index 4bb20542..62b9069c 100644
--- a/runbot_merge/views/templates.xml
+++ b/runbot_merge/views/templates.xml
@@ -430,7 +430,7 @@
                     </a>
                     <a t-attf-href="/web#view_type=form&amp;model=runbot_merge.pull_requests&amp;id={{pr.id}}"
                         class="btn btn-sm btn-secondary align-top float-right"
-                        groups="base.group_user">View in backend</a>
+                        groups="runbot_merge.group_admin">View in backend</a>
                 </h1>
                 <h6>Created by <span t-field="pr.author.display_name"/></h6>
                 <t t-set="tmpl">
@@ -597,7 +597,7 @@ action = batches
                                    title="Open on Github"
                                    t-att-href="p['github_url']"
                                 />
-                                <a groups="base.group_user"
+                                <a groups="runbot_merge.group_admin"
                                    title="Open in Backend"
                                    t-attf-class="fa fa-external-link"
                                    t-att-href="p['backend_url']"