NextERP/runbot
5
0
Fork 0
mirror of https://github.com/odoo/runbot.git synced 2025-03-15 23:45:44 +07:00
Code Issues Actions Packages Projects Releases Wiki Activity

[FIX] runbot: avoid builder crash when no docker to build

Browse Source 
When there is no Dockerfile marked as `to_build`, the runbot builder
crashes in loop trying to find the max of an empty sequence.

With this commit, the builder does not even try to build Dockerfile in
that case.
This commit is contained in:
Christophe Monniez 2024-08-26 10:36:59 +02:00 committed by xdo
parent ccca46c992
commit 5fb0e2f5ab
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
runbot_builder/builder.py
View File

@ -23,10 +23,10 @@ class BuilderClient(RunbotClient):
self.last_docker_update = None
def loop_turn(self):
last_docker_update = max(self.env['runbot.dockerfile'].search([('to_build', '=', True)]).mapped('write_date'))
if self.count == 1 or self.last_docker_update != last_docker_update:
last_docker_updates = self.env['runbot.dockerfile'].search([('to_build', '=', True)]).mapped('write_date')
if self.count == 1 or last_docker_updates and self.last_docker_update != max(last_docker_updates):
self.host._docker_build()
self.last_docker_update = last_docker_update
self.last_docker_update = max(last_docker_updates)
if self.count == 1: # cleanup at second iteration
self.env['runbot.runbot']._source_cleanup()
self.env['runbot.build']._local_cleanup()