From 6b52687ed14a9911f70d29e24828b19f820d8488 Mon Sep 17 00:00:00 2001 From: Xavier-Do Date: Fri, 13 Mar 2020 11:14:56 +0100 Subject: [PATCH] [FIX] runbot: better log list Before intensive python steps, every build exept create build should have logs. This is not true since now many python steps are creating build, leading to 404 links to inexisting logs file. Checking That a step is a docker build looks like a good heuristic since since most of the time the log file will be the one created by docker. In all case we can access other logs files in browsing /logs. A future improvement would be to listdir logs to create all links. --- runbot/models/build_config.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/runbot/models/build_config.py b/runbot/models/build_config.py index c70298f4..5e6aed36 100644 --- a/runbot/models/build_config.py +++ b/runbot/models/build_config.py @@ -573,7 +573,7 @@ class ConfigStep(models.Model): def _has_log(self): self.ensure_one() - return self.job_type != 'create_build' + return self._is_docker_step() class ConfigStepOrder(models.Model):