From 702a52464d941220303acbdee8da2eb96b9c7f22 Mon Sep 17 00:00:00 2001 From: Xavier-Do Date: Tue, 22 Oct 2019 10:31:33 +0200 Subject: [PATCH] [FIX] avoid docker_ps crash if docker is not installed. --- runbot/container.py | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/runbot/container.py b/runbot/container.py index b9dae93c..fdb06b0b 100644 --- a/runbot/container.py +++ b/runbot/container.py @@ -140,7 +140,11 @@ def docker_get_gateway_ip(): def docker_ps(): """Return a list of running containers names""" - docker_ps = subprocess.run(['docker', 'ps', '--format', '{{.Names}}'], stderr=subprocess.DEVNULL, stdout=subprocess.PIPE) + try: + docker_ps = subprocess.run(['docker', 'ps', '--format', '{{.Names}}'], stderr=subprocess.DEVNULL, stdout=subprocess.PIPE) + except FileNotFoundError: + _logger.warning('Docker not found, returning an empty list.') + return [] if docker_ps.returncode != 0: return [] return docker_ps.stdout.decode().strip().split('\n')