From 76cc74fcd9dfd1dbaefc7f3501ceb98e8d483b4f Mon Sep 17 00:00:00 2001
From: Christophe Monniez <moc@odoo.com>
Date: Thu, 22 Dec 2022 14:06:25 +0100
Subject: [PATCH] [IMP] runbot: improve team form and build frontend page

* Hide useless pages on backend team form
* Add a team exceptions page on team form
* Show fixed errors as fixed on front build page
---
 runbot/templates/build.xml       | 6 +++---
 runbot/views/dashboard_views.xml | 7 +++++--
 2 files changed, 8 insertions(+), 5 deletions(-)

diff --git a/runbot/templates/build.xml b/runbot/templates/build.xml
index 0e8e353e..ea648843 100644
--- a/runbot/templates/build.xml
+++ b/runbot/templates/build.xml
@@ -313,7 +313,7 @@
                     </t>
                   </td>
                 </tr>
-                <t t-if="l.error_id">
+                <t t-if="l.with_context(active_test=False).error_id">
                   <t t-set="icon" t-value="'list'"/>
                   <t t-set="error" t-value="l.error_id"/>
                   <t t-set="size" t-value=""/>
@@ -324,8 +324,8 @@
                   </t>
                   <tr>
                     <td/><td/><td/>
-                    <td t-attf-class="bg-info-light {{size}}">
-                      This error is already known.
+                    <td t-attf-class="bg-{{'info' if error.active else 'success'}}-light {{size}}">
+                      This error is already <t t-esc="'known' if error.active else 'fixed'"/>.
                       <a groups="runbot.group_user" t-attf-href="/web#id={{l.error_id.id}}&amp;view_type=form&amp;model=runbot.build.error&amp;menu_id={{env.ref('runbot.runbot_menu_root').id}}" title="View in Backend" target="new">
                         <i t-attf-class="fa fa-{{icon}}"/>
                       </a>
diff --git a/runbot/views/dashboard_views.xml b/runbot/views/dashboard_views.xml
index 9466bcd9..d72d650f 100644
--- a/runbot/views/dashboard_views.xml
+++ b/runbot/views/dashboard_views.xml
@@ -24,7 +24,7 @@
                     </tree>
                   </field>
                 </page>
-                <page string="Team Errors">
+                <page string="Errors" attrs="{'invisible': [('build_error_ids', '=', [])]}">
                   <field name="build_error_ids" nolabel="1" widget="many2many" options="{'not_delete': True, 'no_create': True}"/>
                 </page>
                 <page string="Modules">
@@ -39,10 +39,13 @@
                   <field name="codeowner_ids">
                   </field>
                 </page>
-                <page string="Followed triggers">
+                <page string="Followed triggers" attrs="{'invisible': [('trigger_ids', '=', [])]}">
                   <field name="trigger_ids">
                   </field>
                 </page>
+                <page string="Exceptions" attrs="{'invisible': [('upgrade_exception_ids', '=', [])]}">
+                  <field name="upgrade_exception_ids" readonly="1"/>
+                </page>
               </notebook>
             </sheet>
             <div class="oe_chatter">