From 8364dded3e10f2242b9ee431e0cffe710dd39765 Mon Sep 17 00:00:00 2001 From: Xavier Morel Date: Wed, 22 Jul 2020 10:01:28 +0200 Subject: [PATCH] [ADD] runbot_merge: untested case, failed non-required status Ensure that a non-required status failing does not trigger a notification message. Closes #388 --- runbot_merge/tests/test_basic.py | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/runbot_merge/tests/test_basic.py b/runbot_merge/tests/test_basic.py index 25f318b4..72835bc9 100644 --- a/runbot_merge/tests/test_basic.py +++ b/runbot_merge/tests/test_basic.py @@ -924,12 +924,14 @@ def test_ci_failure_after_review(env, repo, users, config): env.run_crons() with repo: - repo.post_status(prx.head, 'failure', 'ci/runbot') - repo.post_status(prx.head, 'success', 'legal/cla') + repo.post_status(prx.head, 'failure', 'ci/runbot', target_url="https://a") + repo.post_status(prx.head, 'failure', 'legal/cla', target_url="https://b") + repo.post_status(prx.head, 'failure', 'foo/bar', target_url="https://c") env.run_crons() assert prx.comments == [ (users['reviewer'], 'hansen r+'), + (users['user'], "'legal/cla' failed on this reviewed PR.".format_map(users)), (users['user'], "'ci/runbot' failed on this reviewed PR.".format_map(users)), ]