From 83e588d7fe3f0580e342ea5b7abaaf697b463507 Mon Sep 17 00:00:00 2001
From: Xavier Morel <xmo@odoo.com>
Date: Mon, 2 Dec 2024 08:14:20 +0100
Subject: [PATCH] [FIX] runbot_merge: dropdowns for bs5

BS5 namespaced the data-attributes it uses to trigger JS
behaviours. So for dropdowns `@data-toggle` doesn't do anything
anymore, one has to use `@data-bs-toggle`. Missed that while testing
the migrations.

Also seems like `@aria-expanded` was misapplied when I added the
dropdowns:

> When a menu is displayed, the button object that toggles the
> visibility of that menu has aria-expanded="true" set. When the menu
> is hidden, aria-expanded can be omitted. If specified when the menu
> is hidden, it should be set as aria-expanded="false".

Since the dropdowns are hidden by default, the button should be
`@aria-expanded="false"`.
---
 runbot_merge/views/templates.xml | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/runbot_merge/views/templates.xml b/runbot_merge/views/templates.xml
index 6c66dbc0..ab6717c9 100644
--- a/runbot_merge/views/templates.xml
+++ b/runbot_merge/views/templates.xml
@@ -26,9 +26,9 @@
         <div class="dropdown" t-if="staging.heads">
             <button class="btn btn-link dropdown-toggle"
                     type="button"
-                    data-toggle="dropdown"
                     aria-haspopup="true"
-                    aria-expanded="true"
+                    data-bs-toggle="dropdown"
+                    aria-expanded="false"
                     t-attf-title="Staged at {{staging.staged_at}}Z for {{round(staging.staging_duration)}}s"
             >
                 <t t-out="0"/>
@@ -286,9 +286,9 @@
                                         <li class="dropdown" t-if="first_pr">
                                             <button class="btn btn-link dropdown-toggle"
                                                     type="button"
-                                                    data-toggle="dropdown"
                                                     aria-haspopup="true"
-                                                    aria-expanded="true"
+                                                    data-bs-toggle="dropdown"
+                                                    aria-expanded="false"
                                             >
                                                 <t t-esc="first_pr.label"/>
                                                 <span class="caret"></span>