NextERP/runbot
5
0
Fork 0
mirror of https://github.com/odoo/runbot.git synced 2025-03-27 13:25:47 +07:00
Code Issues Actions Packages Projects Releases Wiki Activity

[FIX]: fix codeowner

Browse Source 
A corner case was discovered when a pr is open but the pr is not in the
codeowner commits.
This commit is contained in:
Xavier-Do 2022-12-23 18:38:10 +01:00 committed by xdo
parent ad573d64cf
commit 910843f06d
2 changed files with 7 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
runbot/models/build_config.py
View File

@ -1116,9 +1116,11 @@ class ConfigStep(models.Model):
success = False success = False
return success return success
def _modified_files(self, build, commit_link_links = None): def _modified_files(self, build, commit_link_links=None):
modified_files = {} modified_files = {}
for commit_link in commit_link_links or build.params_id.commit_link_ids: if commit_link_links is None:
commit_link_links = build.params_id.commit_link_ids
for commit_link in commit_link_links:
commit = commit_link.commit_id commit = commit_link.commit_id
modified = commit.repo_id._git(['diff', '--name-only', '%s..%s' % (commit_link.merge_base_commit_id.name, commit.name)]) modified = commit.repo_id._git(['diff', '--name-only', '%s..%s' % (commit_link.merge_base_commit_id.name, commit.name)])
if modified: if modified:

5
runbot/models/build_config_codeowner.py
View File

@ -29,7 +29,7 @@ class ConfigStep(models.Model):
for codeowner in codeowners: for codeowner in codeowners:
github_teams = codeowner._get_github_teams() github_teams = codeowner._get_github_teams()
if github_teams and codeowner.regex and (codeowner._match_version(version_id)): if github_teams and codeowner.regex and (codeowner._match_version(version_id)):
team_set = regexes.setdefault(codeowner.regex.strip(), set()) team_set = regexes.setdefault(codeowner.regex.strip(), set())
team_set |= set(t.strip() for t in github_teams) team_set |= set(t.strip() for t in github_teams)
return list(regexes.items()) return list(regexes.items())
@ -73,7 +73,8 @@ class ConfigStep(models.Model):
if not self._check_limits(build): if not self._check_limits(build):
return return
prs = bundle.branch_ids.filtered(lambda branch: branch.is_pr and branch.alive) build_repositories = build.params_id.commit_link_ids.commit_id.repo_id
prs = bundle.branch_ids.filtered(lambda branch: branch.is_pr and branch.alive and (branch.remote_id.repo_id in build_repositories))
# skip draft pr # skip draft pr
draft_prs = prs.filtered(lambda pr: pr.draft) draft_prs = prs.filtered(lambda pr: pr.draft)