NextERP/runbot
5
0
Fork 0
mirror of https://github.com/odoo/runbot.git synced 2025-03-27 13:25:47 +07:00
Code Issues Actions Packages Projects Releases Wiki Activity

[FIX] forwardport: type error

Browse Source 
`groupby` returns an iterator of `(key, list[value])`, not a
recordset. So `BaseModel.__or__` is invalid.

I missed that bit because I didn't bother writing a test where a PR
has more than 6 months and triggers generating / sending emails, but
turns out we do have those in the production database, and as a result
the mergebot hasn't sent an outstanding fw notification since I
deployed 892fce4ddf in early
february (oops).

Thanks to @clbr-odoo for the notification / report of the issue.
This commit is contained in:
Xavier Morel 2025-02-20 14:01:46 +01:00
parent d9b2441549
commit 93a52b5f43
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
forwardport/models/project.py
View File

@ -544,9 +544,9 @@ stderr:
# after 6 months, start sending emails # after 6 months, start sending emails
if age > datetime.timedelta(weeks=26): if age > datetime.timedelta(weeks=26):
if author := source.author.email: if author := source.author.email:
emails[author] |= prs emails[author] = emails[author].union(*prs)
if reviewer := source.reviewed_by.email: if reviewer := source.reviewed_by.email:
emails[reviewer] |= prs emails[reviewer] = emails[reviewer].union(*prs)
self.env.ref('runbot_merge.forwardport.reminder')._send( self.env.ref('runbot_merge.forwardport.reminder')._send(
repository=pr.repository, repository=pr.repository,
pull_request=pr.number, pull_request=pr.number,