mirror of
https://github.com/odoo/runbot.git
synced 2025-03-27 13:25:47 +07:00
[IMP] runbot: diffable tracking in chatter
The python steps can be long and interresting to track but the change is actually hard to see since a block of code is logged instead of the diff. Also, the whitespaces are not preserverd since we are note in a <pre> block making it hard to read. This proposes an alternative to display python code tracking values as a diff with options to copu the raw content of the old and new version. (as well as showing unchanged lines or not)
This commit is contained in:
parent
727d71d103
commit
96808acb37
@ -62,7 +62,8 @@
|
|||||||
|
|
||||||
'assets': {
|
'assets': {
|
||||||
'web.assets_backend': [
|
'web.assets_backend': [
|
||||||
'runbot/static/src/js/fields.js',
|
'runbot/static/src/libs/diff_match_patch/diff_match_patch.js',
|
||||||
|
'runbot/static/src/js/fields/*',
|
||||||
],
|
],
|
||||||
'runbot.assets_frontend': [
|
'runbot.assets_frontend': [
|
||||||
'/web/static/lib/bootstrap/dist/css/bootstrap.css',
|
'/web/static/lib/bootstrap/dist/css/bootstrap.css',
|
||||||
|
81
runbot/static/src/js/fields/tracking_value.js
Normal file
81
runbot/static/src/js/fields/tracking_value.js
Normal file
@ -0,0 +1,81 @@
|
|||||||
|
/** @odoo-module **/
|
||||||
|
|
||||||
|
|
||||||
|
import { useState} from "@odoo/owl";
|
||||||
|
import { registerMessagingComponent, getMessagingComponent, unregisterMessagingComponent } from '@mail/utils/messaging_component';
|
||||||
|
|
||||||
|
const MailTrackingValue = getMessagingComponent('TrackingValue');
|
||||||
|
export class TrackingValue extends MailTrackingValue {
|
||||||
|
static template = 'runbot.TrackingValue'
|
||||||
|
|
||||||
|
setup() {
|
||||||
|
this.display = useState({kept: false});
|
||||||
|
super.setup()
|
||||||
|
this.oldValue = this.props.value.oldValue.formattedValueOrNone;
|
||||||
|
this.newValue = this.props.value.newValue.formattedValueOrNone;
|
||||||
|
this.multiline = (
|
||||||
|
(this.oldValue && this.oldValue.includes('\n'))
|
||||||
|
&&
|
||||||
|
(this.newValue && this.newValue.includes('\n'))
|
||||||
|
)
|
||||||
|
if (this.multiline) {
|
||||||
|
var diff = this.makeDiff(this.oldValue, this.newValue);
|
||||||
|
this.lines = this.prepareForRendering(diff);
|
||||||
|
}
|
||||||
|
}
|
||||||
|
toggleKept() {
|
||||||
|
this.display.kept = !this.display.kept;
|
||||||
|
}
|
||||||
|
makeDiff(text1, text2) {
|
||||||
|
var dmp = new diff_match_patch();
|
||||||
|
var a = dmp.diff_linesToChars_(text1, text2);
|
||||||
|
var lineText1 = a.chars1;
|
||||||
|
var lineText2 = a.chars2;
|
||||||
|
var lineArray = a.lineArray;
|
||||||
|
var diffs = dmp.diff_main(lineText1, lineText2, false);
|
||||||
|
dmp.diff_charsToLines_(diffs, lineArray);
|
||||||
|
dmp.diff_cleanupSemantic(diffs);
|
||||||
|
return diffs;
|
||||||
|
}
|
||||||
|
prepareForRendering(diffs) {
|
||||||
|
var lines = [];
|
||||||
|
var pre_line_counter = 0
|
||||||
|
var post_line_counter = 0
|
||||||
|
for (var x = 0; x < diffs.length; x++) {
|
||||||
|
var diff_type = diffs[x][0];
|
||||||
|
var data = diffs[x][1];
|
||||||
|
var data_lines = data.split('\n');
|
||||||
|
for (var line_index in data_lines) {
|
||||||
|
var line = data_lines[line_index];
|
||||||
|
line = line.replace(/&/g, '&');
|
||||||
|
line = line.replace(/</g, '<');
|
||||||
|
line = line.replace(/>/g, '>');
|
||||||
|
//text = text.replace(/\n/g, '<br>');
|
||||||
|
//text = text.replace(/ /g, '  ');
|
||||||
|
if (diff_type == -1) {
|
||||||
|
lines.push({type:'removed', pre_line_counter: pre_line_counter, post_line_counter: '-', line: line})
|
||||||
|
pre_line_counter += 1
|
||||||
|
} else if (diff_type == 0) {
|
||||||
|
lines.push({type:'kept', pre_line_counter: '', post_line_counter: post_line_counter, line: line})
|
||||||
|
pre_line_counter += 1
|
||||||
|
post_line_counter +=1
|
||||||
|
} else if (diff_type == 1) {
|
||||||
|
lines.push({type:'added', pre_line_counter: '+', post_line_counter: post_line_counter, line: line})
|
||||||
|
post_line_counter +=1
|
||||||
|
}
|
||||||
|
}
|
||||||
|
}
|
||||||
|
return lines;
|
||||||
|
};
|
||||||
|
|
||||||
|
copyOldToClipboard() {
|
||||||
|
navigator.clipboard.writeText(this.oldValue);
|
||||||
|
}
|
||||||
|
|
||||||
|
copyNewToClipboard() {
|
||||||
|
navigator.clipboard.writeText(this.newValue);
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
unregisterMessagingComponent({name:'TrackingValue'});
|
||||||
|
registerMessagingComponent(TrackingValue);
|
29
runbot/static/src/js/fields/tracking_value.scss
Normal file
29
runbot/static/src/js/fields/tracking_value.scss
Normal file
@ -0,0 +1,29 @@
|
|||||||
|
.code_diff {
|
||||||
|
white-space: nowrap;
|
||||||
|
overflow-x: auto;
|
||||||
|
font: 12px/normal 'Monaco', 'Menlo', 'Ubuntu Mono', 'Consolas', 'source-code-pro', monospace;
|
||||||
|
|
||||||
|
.col_number {
|
||||||
|
background-color: #EEE;
|
||||||
|
}
|
||||||
|
|
||||||
|
.added {
|
||||||
|
background:#a1f1a1;
|
||||||
|
}
|
||||||
|
|
||||||
|
.removed {
|
||||||
|
background:#f3a3a3;
|
||||||
|
}
|
||||||
|
|
||||||
|
.code {
|
||||||
|
white-space: pre-wrap;
|
||||||
|
}
|
||||||
|
.diff_line {
|
||||||
|
background-color: #FFF;
|
||||||
|
}
|
||||||
|
|
||||||
|
.diff_line:hover {
|
||||||
|
filter: brightness(92%);
|
||||||
|
}
|
||||||
|
|
||||||
|
}
|
32
runbot/static/src/js/fields/tracking_value.xml
Normal file
32
runbot/static/src/js/fields/tracking_value.xml
Normal file
@ -0,0 +1,32 @@
|
|||||||
|
<?xml version="1.0" encoding="utf-8"?>
|
||||||
|
<templates>
|
||||||
|
<t t-name="runbot.TrackingValue" owl="1">
|
||||||
|
<div class="o_TrackingValue o_RunbotTrackingValue d-flex align-items-center flex-wrap mb-1" t-attf-class="{{ className }}" role="group" t-ref="root">
|
||||||
|
<t t-if="multiline">
|
||||||
|
<div class="btn-group btn-group-toggle mb-1">
|
||||||
|
<button class="btn btn-sm btn-outline-primary" t-on-click="copyOldToClipboard">Copy old value to clipboard</button>
|
||||||
|
<button class="btn btn-sm btn-outline-primary" t-on-click="toggleKept">Toggle context</button>
|
||||||
|
<button class="btn btn-sm btn-outline-primary" t-on-click="copyNewToClipboard">Copy new value to clipboard</button>
|
||||||
|
</div>
|
||||||
|
<div class="o_TrackingValue_fieldName fst-italic text-muted ms-1 " t-esc="'(' + trackingValue.formattedChangedField + ')'"/>
|
||||||
|
<div class="code_diff">
|
||||||
|
<table>
|
||||||
|
<t t-foreach="lines" t-as="line" t-key="line_index">
|
||||||
|
<tr t-if="display.kept or line.type!=='kept'">
|
||||||
|
<td class="col_number" t-esc="line.pre_line_counter"/>
|
||||||
|
<td class="col_number" t-esc="line.post_line_counter"/>
|
||||||
|
<td class="code" t-att-class="line.type" t-esc="line.line"/>
|
||||||
|
</tr>
|
||||||
|
</t>
|
||||||
|
</table>
|
||||||
|
</div>
|
||||||
|
</t>
|
||||||
|
<t t-else="">
|
||||||
|
<span class="o_TrackingValue_oldValue me-1 px-1 text-muted fw-bold" t-esc="trackingValue.oldValue.formattedValueOrNone" t-att-class="{ 'fst-italic': !trackingValue.oldValue.formattedValue }"/>
|
||||||
|
<i class="o_TrackingValue_separator fa fa-long-arrow-right mx-1 text-600" title="Changed" role="img" aria-label="Changed"/>
|
||||||
|
<span class="o_TrackingValue_newValue me-1 fw-bold text-info" t-esc="trackingValue.newValue.formattedValueOrNone" t-att-class="{ 'fst-italic': !trackingValue.newValue.formattedValue }"/>
|
||||||
|
<span class="o_TrackingValue_fieldName fst-italic text-muted" t-esc="'(' + trackingValue.formattedChangedField + ')'"/>
|
||||||
|
</t>
|
||||||
|
</div>
|
||||||
|
</t>
|
||||||
|
</templates>
|
204
runbot/static/src/libs/diff_match_patch/LICENSE
Normal file
204
runbot/static/src/libs/diff_match_patch/LICENSE
Normal file
@ -0,0 +1,204 @@
|
|||||||
|
Source: https://github.com/google/diff-match-patch/tree/master
|
||||||
|
|
||||||
|
|
||||||
|
Apache License
|
||||||
|
Version 2.0, January 2004
|
||||||
|
http://www.apache.org/licenses/
|
||||||
|
|
||||||
|
TERMS AND CONDITIONS FOR USE, REPRODUCTION, AND DISTRIBUTION
|
||||||
|
|
||||||
|
1. Definitions.
|
||||||
|
|
||||||
|
"License" shall mean the terms and conditions for use, reproduction,
|
||||||
|
and distribution as defined by Sections 1 through 9 of this document.
|
||||||
|
|
||||||
|
"Licensor" shall mean the copyright owner or entity authorized by
|
||||||
|
the copyright owner that is granting the License.
|
||||||
|
|
||||||
|
"Legal Entity" shall mean the union of the acting entity and all
|
||||||
|
other entities that control, are controlled by, or are under common
|
||||||
|
control with that entity. For the purposes of this definition,
|
||||||
|
"control" means (i) the power, direct or indirect, to cause the
|
||||||
|
direction or management of such entity, whether by contract or
|
||||||
|
otherwise, or (ii) ownership of fifty percent (50%) or more of the
|
||||||
|
outstanding shares, or (iii) beneficial ownership of such entity.
|
||||||
|
|
||||||
|
"You" (or "Your") shall mean an individual or Legal Entity
|
||||||
|
exercising permissions granted by this License.
|
||||||
|
|
||||||
|
"Source" form shall mean the preferred form for making modifications,
|
||||||
|
including but not limited to software source code, documentation
|
||||||
|
source, and configuration files.
|
||||||
|
|
||||||
|
"Object" form shall mean any form resulting from mechanical
|
||||||
|
transformation or translation of a Source form, including but
|
||||||
|
not limited to compiled object code, generated documentation,
|
||||||
|
and conversions to other media types.
|
||||||
|
|
||||||
|
"Work" shall mean the work of authorship, whether in Source or
|
||||||
|
Object form, made available under the License, as indicated by a
|
||||||
|
copyright notice that is included in or attached to the work
|
||||||
|
(an example is provided in the Appendix below).
|
||||||
|
|
||||||
|
"Derivative Works" shall mean any work, whether in Source or Object
|
||||||
|
form, that is based on (or derived from) the Work and for which the
|
||||||
|
editorial revisions, annotations, elaborations, or other modifications
|
||||||
|
represent, as a whole, an original work of authorship. For the purposes
|
||||||
|
of this License, Derivative Works shall not include works that remain
|
||||||
|
separable from, or merely link (or bind by name) to the interfaces of,
|
||||||
|
the Work and Derivative Works thereof.
|
||||||
|
|
||||||
|
"Contribution" shall mean any work of authorship, including
|
||||||
|
the original version of the Work and any modifications or additions
|
||||||
|
to that Work or Derivative Works thereof, that is intentionally
|
||||||
|
submitted to Licensor for inclusion in the Work by the copyright owner
|
||||||
|
or by an individual or Legal Entity authorized to submit on behalf of
|
||||||
|
the copyright owner. For the purposes of this definition, "submitted"
|
||||||
|
means any form of electronic, verbal, or written communication sent
|
||||||
|
to the Licensor or its representatives, including but not limited to
|
||||||
|
communication on electronic mailing lists, source code control systems,
|
||||||
|
and issue tracking systems that are managed by, or on behalf of, the
|
||||||
|
Licensor for the purpose of discussing and improving the Work, but
|
||||||
|
excluding communication that is conspicuously marked or otherwise
|
||||||
|
designated in writing by the copyright owner as "Not a Contribution."
|
||||||
|
|
||||||
|
"Contributor" shall mean Licensor and any individual or Legal Entity
|
||||||
|
on behalf of whom a Contribution has been received by Licensor and
|
||||||
|
subsequently incorporated within the Work.
|
||||||
|
|
||||||
|
2. Grant of Copyright License. Subject to the terms and conditions of
|
||||||
|
this License, each Contributor hereby grants to You a perpetual,
|
||||||
|
worldwide, non-exclusive, no-charge, royalty-free, irrevocable
|
||||||
|
copyright license to reproduce, prepare Derivative Works of,
|
||||||
|
publicly display, publicly perform, sublicense, and distribute the
|
||||||
|
Work and such Derivative Works in Source or Object form.
|
||||||
|
|
||||||
|
3. Grant of Patent License. Subject to the terms and conditions of
|
||||||
|
this License, each Contributor hereby grants to You a perpetual,
|
||||||
|
worldwide, non-exclusive, no-charge, royalty-free, irrevocable
|
||||||
|
(except as stated in this section) patent license to make, have made,
|
||||||
|
use, offer to sell, sell, import, and otherwise transfer the Work,
|
||||||
|
where such license applies only to those patent claims licensable
|
||||||
|
by such Contributor that are necessarily infringed by their
|
||||||
|
Contribution(s) alone or by combination of their Contribution(s)
|
||||||
|
with the Work to which such Contribution(s) was submitted. If You
|
||||||
|
institute patent litigation against any entity (including a
|
||||||
|
cross-claim or counterclaim in a lawsuit) alleging that the Work
|
||||||
|
or a Contribution incorporated within the Work constitutes direct
|
||||||
|
or contributory patent infringement, then any patent licenses
|
||||||
|
granted to You under this License for that Work shall terminate
|
||||||
|
as of the date such litigation is filed.
|
||||||
|
|
||||||
|
4. Redistribution. You may reproduce and distribute copies of the
|
||||||
|
Work or Derivative Works thereof in any medium, with or without
|
||||||
|
modifications, and in Source or Object form, provided that You
|
||||||
|
meet the following conditions:
|
||||||
|
|
||||||
|
(a) You must give any other recipients of the Work or
|
||||||
|
Derivative Works a copy of this License; and
|
||||||
|
|
||||||
|
(b) You must cause any modified files to carry prominent notices
|
||||||
|
stating that You changed the files; and
|
||||||
|
|
||||||
|
(c) You must retain, in the Source form of any Derivative Works
|
||||||
|
that You distribute, all copyright, patent, trademark, and
|
||||||
|
attribution notices from the Source form of the Work,
|
||||||
|
excluding those notices that do not pertain to any part of
|
||||||
|
the Derivative Works; and
|
||||||
|
|
||||||
|
(d) If the Work includes a "NOTICE" text file as part of its
|
||||||
|
distribution, then any Derivative Works that You distribute must
|
||||||
|
include a readable copy of the attribution notices contained
|
||||||
|
within such NOTICE file, excluding those notices that do not
|
||||||
|
pertain to any part of the Derivative Works, in at least one
|
||||||
|
of the following places: within a NOTICE text file distributed
|
||||||
|
as part of the Derivative Works; within the Source form or
|
||||||
|
documentation, if provided along with the Derivative Works; or,
|
||||||
|
within a display generated by the Derivative Works, if and
|
||||||
|
wherever such third-party notices normally appear. The contents
|
||||||
|
of the NOTICE file are for informational purposes only and
|
||||||
|
do not modify the License. You may add Your own attribution
|
||||||
|
notices within Derivative Works that You distribute, alongside
|
||||||
|
or as an addendum to the NOTICE text from the Work, provided
|
||||||
|
that such additional attribution notices cannot be construed
|
||||||
|
as modifying the License.
|
||||||
|
|
||||||
|
You may add Your own copyright statement to Your modifications and
|
||||||
|
may provide additional or different license terms and conditions
|
||||||
|
for use, reproduction, or distribution of Your modifications, or
|
||||||
|
for any such Derivative Works as a whole, provided Your use,
|
||||||
|
reproduction, and distribution of the Work otherwise complies with
|
||||||
|
the conditions stated in this License.
|
||||||
|
|
||||||
|
5. Submission of Contributions. Unless You explicitly state otherwise,
|
||||||
|
any Contribution intentionally submitted for inclusion in the Work
|
||||||
|
by You to the Licensor shall be under the terms and conditions of
|
||||||
|
this License, without any additional terms or conditions.
|
||||||
|
Notwithstanding the above, nothing herein shall supersede or modify
|
||||||
|
the terms of any separate license agreement you may have executed
|
||||||
|
with Licensor regarding such Contributions.
|
||||||
|
|
||||||
|
6. Trademarks. This License does not grant permission to use the trade
|
||||||
|
names, trademarks, service marks, or product names of the Licensor,
|
||||||
|
except as required for reasonable and customary use in describing the
|
||||||
|
origin of the Work and reproducing the content of the NOTICE file.
|
||||||
|
|
||||||
|
7. Disclaimer of Warranty. Unless required by applicable law or
|
||||||
|
agreed to in writing, Licensor provides the Work (and each
|
||||||
|
Contributor provides its Contributions) on an "AS IS" BASIS,
|
||||||
|
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or
|
||||||
|
implied, including, without limitation, any warranties or conditions
|
||||||
|
of TITLE, NON-INFRINGEMENT, MERCHANTABILITY, or FITNESS FOR A
|
||||||
|
PARTICULAR PURPOSE. You are solely responsible for determining the
|
||||||
|
appropriateness of using or redistributing the Work and assume any
|
||||||
|
risks associated with Your exercise of permissions under this License.
|
||||||
|
|
||||||
|
8. Limitation of Liability. In no event and under no legal theory,
|
||||||
|
whether in tort (including negligence), contract, or otherwise,
|
||||||
|
unless required by applicable law (such as deliberate and grossly
|
||||||
|
negligent acts) or agreed to in writing, shall any Contributor be
|
||||||
|
liable to You for damages, including any direct, indirect, special,
|
||||||
|
incidental, or consequential damages of any character arising as a
|
||||||
|
result of this License or out of the use or inability to use the
|
||||||
|
Work (including but not limited to damages for loss of goodwill,
|
||||||
|
work stoppage, computer failure or malfunction, or any and all
|
||||||
|
other commercial damages or losses), even if such Contributor
|
||||||
|
has been advised of the possibility of such damages.
|
||||||
|
|
||||||
|
9. Accepting Warranty or Additional Liability. While redistributing
|
||||||
|
the Work or Derivative Works thereof, You may choose to offer,
|
||||||
|
and charge a fee for, acceptance of support, warranty, indemnity,
|
||||||
|
or other liability obligations and/or rights consistent with this
|
||||||
|
License. However, in accepting such obligations, You may act only
|
||||||
|
on Your own behalf and on Your sole responsibility, not on behalf
|
||||||
|
of any other Contributor, and only if You agree to indemnify,
|
||||||
|
defend, and hold each Contributor harmless for any liability
|
||||||
|
incurred by, or claims asserted against, such Contributor by reason
|
||||||
|
of your accepting any such warranty or additional liability.
|
||||||
|
|
||||||
|
END OF TERMS AND CONDITIONS
|
||||||
|
|
||||||
|
APPENDIX: How to apply the Apache License to your work.
|
||||||
|
|
||||||
|
To apply the Apache License to your work, attach the following
|
||||||
|
boilerplate notice, with the fields enclosed by brackets "[]"
|
||||||
|
replaced with your own identifying information. (Don't include
|
||||||
|
the brackets!) The text should be enclosed in the appropriate
|
||||||
|
comment syntax for the file format. We also recommend that a
|
||||||
|
file or class name and description of purpose be included on the
|
||||||
|
same "printed page" as the copyright notice for easier
|
||||||
|
identification within third-party archives.
|
||||||
|
|
||||||
|
Copyright [yyyy] [name of copyright owner]
|
||||||
|
|
||||||
|
Licensed under the Apache License, Version 2.0 (the "License");
|
||||||
|
you may not use this file except in compliance with the License.
|
||||||
|
You may obtain a copy of the License at
|
||||||
|
|
||||||
|
http://www.apache.org/licenses/LICENSE-2.0
|
||||||
|
|
||||||
|
Unless required by applicable law or agreed to in writing, software
|
||||||
|
distributed under the License is distributed on an "AS IS" BASIS,
|
||||||
|
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
||||||
|
See the License for the specific language governing permissions and
|
||||||
|
limitations under the License.
|
2236
runbot/static/src/libs/diff_match_patch/diff_match_patch.js
Normal file
2236
runbot/static/src/libs/diff_match_patch/diff_match_patch.js
Normal file
File diff suppressed because it is too large
Load Diff
Loading…
Reference in New Issue
Block a user