From 97001fbf722661f329d19ef47ff090b6cf11f4bc Mon Sep 17 00:00:00 2001 From: Christophe Simonis Date: Tue, 26 Jul 2016 18:28:24 +0200 Subject: [PATCH] [FIX] runbot: remove useless commit() This commit() is the root cause of the famous false-positive error `_check_module_names invalid module names, ignored: False`. The first step (pull code) is a long one. if a push-hook request happen during this step, the current transaction wont be able to be commited (the list of module to test is written on the build). Due to this early commit(), the build is left in an intermediate state with the module list unpopulated (=False). --- runbot/runbot.py | 1 - 1 file changed, 1 deletion(-) diff --git a/runbot/runbot.py b/runbot/runbot.py index 488d6f59..cbe6e042 100644 --- a/runbot/runbot.py +++ b/runbot/runbot.py @@ -1073,7 +1073,6 @@ class runbot_build(osv.osv): 'job_end': False, } build.write(values) - cr.commit() else: # check if current job is finished lock_path = build.path('logs', '%s.lock' % build.job)