NextERP/runbot
5
0
Fork 0
mirror of https://github.com/odoo/runbot.git synced 2025-03-23 03:15:58 +07:00
Code Issues Actions Packages Projects Releases Wiki Activity

[FIX] runbot: remove --user from pip

Browse Source 
Experimentations are done to use venv inside the docker to avoid having
a strong dependency on the user creation to install pip.

The default --user option of pip is not compatible with the venv causing
error when the install really need to make some operation.

Looking at the commit that introduced it e1161a03e it wasn't really
usefull but mostly added as a good practice in case we wish to use the
same command on a non debian based system.
This commit is contained in:
Xavier-Do 2025-03-18 13:52:33 +01:00 committed by Christophe Monniez
parent 50170c5f6e
commit 9dae3f88dd
2 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
runbot/models/build.py
View File

@ -1105,7 +1105,7 @@ class BuildResult(models.Model):
if os.path.isfile(commit_id._source_path('requirements.txt')):
repo_dir = self._docker_source_folder(commit_id)
requirement_path = os.sep.join([repo_dir, 'requirements.txt'])
pres.append([f'python{py_version}', '-m', 'pip', 'install', '--user', '--progress-bar', 'off', '-r', f'{requirement_path}'])
pres.append([f'python{py_version}', '-m', 'pip', 'install', '--progress-bar', 'off', '-r', f'{requirement_path}'])
addons_paths = self._get_addons_path()
(server_commit, server_file) = self._get_server_info()

2
runbot/tests/test_build.py
View File

@ -397,7 +397,7 @@ class TestBuildResult(RunbotCase):
'params_id': self.server_params.id,
})
cmd = build._cmd(py_version=3)
self.assertIn('python3 -m pip install --user --progress-bar off -r server/requirements.txt'.split(), cmd.pres)
self.assertIn('python3 -m pip install --progress-bar off -r server/requirements.txt'.split(), cmd.pres)
self.assertIn(custom_pre, cmd.pres)
self.assertIn(custom_post, cmd.posts)