From a8b3d6e205a4a02e444cbe390ef9f133005f258c Mon Sep 17 00:00:00 2001 From: Christophe Monniez Date: Wed, 9 Oct 2024 13:53:35 +0200 Subject: [PATCH] [FIX] runbot: avoid copying always_pull field This commit will prevent people acting like cowboys to break the whole system by duplicating a Dockerfile without disabling the always_pull field. --- runbot/models/docker.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/runbot/models/docker.py b/runbot/models/docker.py index c61971a9..cc4622f9 100644 --- a/runbot/models/docker.py +++ b/runbot/models/docker.py @@ -128,7 +128,7 @@ class Dockerfile(models.Model): arch_base = fields.Text(related='template_id.arch_base', readonly=False, related_sudo=True) dockerfile = fields.Text(compute='_compute_dockerfile', tracking=True) to_build = fields.Boolean('To Build', help='Build Dockerfile. Check this when the Dockerfile is ready.', default=False) - always_pull = fields.Boolean('Always pull', help='Always Pull on the hosts, not only at the use time', default=False, tracking=True) + always_pull = fields.Boolean('Always pull', help='Always Pull on the hosts, not only at the use time', default=False, tracking=True, copy=False) version_ids = fields.One2many('runbot.version', 'dockerfile_id', string='Versions') description = fields.Text('Description') view_ids = fields.Many2many('ir.ui.view', compute='_compute_view_ids', groups="runbot.group_runbot_admin")